From 9c3b3efb3c7ca82a90dea8ca63ec080639f150a9 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Mon, 24 Oct 2022 23:52:34 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- pre-process.py | 63 +++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 60 insertions(+), 3 deletions(-) diff --git a/pre-process.py b/pre-process.py index ebafd08..c61647d 100644 --- a/pre-process.py +++ b/pre-process.py @@ -159,15 +159,72 @@ def process_test_data(): print('Extracting cars_train.tgz...') if not os.path.exists('cars_train'): with tarfile.open('cars_train.tgz', "r:gz") as tar: - tar.extractall() +def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + +def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + +safe_extract(tar) print('Extracting cars_test.tgz...') if not os.path.exists('cars_test'): with tarfile.open('cars_test.tgz', "r:gz") as tar: - tar.extractall() +def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + +def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + +safe_extract(tar) print('Extracting car_devkit.tgz...') if not os.path.exists('devkit'): with tarfile.open('car_devkit.tgz', "r:gz") as tar: - tar.extractall() +def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + +def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + +safe_extract(tar) cars_meta = scipy.io.loadmat('devkit/cars_meta') class_names = cars_meta['class_names'] # shape=(1, 196)