Skip to content

Subscribe message type 'subscribe.accepted' used instead of spec's 'job.subscribed' (§7.6) #151

@nficano

Description

@nficano

Category: spec-conformance Severity: major
Location: src/Messages/Subscriptions/SubscribeAccepted.php:12-37
Spec: ARCP v1.1 §7.6

What

Spec §7.6 defines the response wire type job.subscribed carrying {job_id, current_status, agent, lease, parent_job_id, trace_id, subscribed_from, replayed}. SDK uses subscribe.accepted with only subscription_id.

Evidence

final readonly class SubscribeAccepted extends MessageType
{
    public function __construct(public SubscriptionId $subscriptionId)
    {
    }

    public static function typeName(): string
    {
        return 'subscribe.accepted';
    }

    public function toArray(): array
    {
        return ['subscription_id' => (string) $this->subscriptionId];
    }

Proposed fix

Replace SubscribeAccepted with JobSubscribed; typeName 'job.subscribed'; populate all spec fields.

Acceptance criteria

  • Subscribe response envelope is type: "job.subscribed" with the spec payload.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions