fix: resolve ruff/pyright CI failures in tests and runtime

CI failed fast at the ruff lint step, masking downstream format and
pyright failures. Address all of them so the test job is green:

- ruff lint: sort imports (I001), rename the LeaseConstraints alias off
  an all-caps acronym (N817), prefer itertools.pairwise over zip (RUF007),
  split a compound assertion (PT018), and collapse a subset loop into
  all()/any() (SIM110).
- ruff format: reformat the touched test/runtime modules.
- pyright: cast the narrowed session.error details dict to dict[str, Any]
  so request_id no longer resolves to an unknown type.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: nficano

examples/cancel/client.py

@@ -7,8 +7,8 @@
 import os
 import sys
 
-from arcp import ARCPError, ClientInfo, WebSocketTransport
 from arcp import ARCPCancelledError as ARCPCancelled
+from arcp import ARCPError, ClientInfo, WebSocketTransport
 from arcp.client import ARCPClient
 
 PORT = int(os.environ.get("ARCP_DEMO_PORT", "7883"))

src/arcp/_client/dispatch.py

@@ -6,7 +6,7 @@
 
 import asyncio
 from collections.abc import Awaitable, Callable
-from typing import TYPE_CHECKING, Any
+from typing import TYPE_CHECKING, Any, cast
 
 from .._envelope import Envelope
 from .._errors import InternalError, error_from_payload
@@ -77,7 +77,9 @@ async def _on_session_ping(client: ARCPClient, env: Envelope) -> None:
 async def _on_session_error(client: ARCPClient, env: Envelope) -> None:
     err = error_from_payload(env.payload)
     details = env.payload.get("details")
-    request_id = details.get("request_id") if isinstance(details, dict) else None
+    request_id = (
+        cast("dict[str, Any]", details).get("request_id") if isinstance(details, dict) else None
+    )
     # A per-request dispatch failure (e.g. an unknown agent on one submit)
     # carries the originating request_id; fail only that request so unrelated
     # in-flight job handles keep running (#71). Errors without a request_id

src/arcp/_runtime/_handlers.py

@@ -34,8 +34,8 @@
     SessionPingPayload,
     SessionPongPayload,
 )
-from .._transport.base import TransportClosed
 from .._time import now_iso_z as _now_iso
+from .._transport.base import TransportClosed
 from .._ulid import new_envelope_id, new_job_id
 from .credentials import Credential, JobCredentialContext
 from .job import Job

src/arcp/_runtime/lease.py

@@ -236,11 +236,7 @@ def validate_lease_op(
     patterns = lease.get(ctx.capability)
     # Filesystem targets are canonicalized (resolving `..`) so traversal cannot
     # escape a segment-anchored grant before matching.
-    target = (
-        canonicalize_target(ctx.target)
-        if ctx.capability in _PATH_CAPABILITIES
-        else ctx.target
-    )
+    target = canonicalize_target(ctx.target) if ctx.capability in _PATH_CAPABILITIES else ctx.target
     if not patterns or not _glob_match(patterns, target):
         raise PermissionDeniedError(
             f"operation {ctx.capability}:{ctx.target} not permitted by lease"
@@ -271,10 +267,7 @@ def _is_subset_pattern(child_patterns: list[str], parent_patterns: list[str]) ->
     containment, not by matching the child *pattern string* against the parent
     glob (which let a wider child like `/data/**` pass under `/data/*`).
     """
-    for cp in child_patterns:
-        if not any(_glob_lang_subset(cp, pp) for pp in parent_patterns):
-            return False
-    return True
+    return all(any(_glob_lang_subset(cp, pp) for pp in parent_patterns) for cp in child_patterns)
 
 
 def _patterns_are_subset(child: Lease, parent: Lease) -> bool:

tests/state/test_idempotency_atomic.py

@@ -11,13 +11,13 @@
     RuntimeInfo,
     pair_memory_transports,
 )
+from arcp._messages.execution import Lease
 from arcp._runtime.credentials import (
     Credential,
     CredentialConstraints,
     InMemoryRevocationLog,
     JobCredentialContext,
 )
-from arcp._messages.execution import Lease
 from arcp.client import ARCPClient
 from arcp.runtime import ARCPRuntime, StaticBearerVerifier
 
@@ -81,8 +81,12 @@ async def agent(input_value, ctx):
     try:
         key = "dup-key"
         h1, h2 = await asyncio.gather(
-            c1.submit(agent="a", input=1, idempotency_key=key, lease_request={"model.use": ["m/*"]}),
-            c2.submit(agent="a", input=1, idempotency_key=key, lease_request={"model.use": ["m/*"]}),
+            c1.submit(
+                agent="a", input=1, idempotency_key=key, lease_request={"model.use": ["m/*"]}
+            ),
+            c2.submit(
+                agent="a", input=1, idempotency_key=key, lease_request={"model.use": ["m/*"]}
+            ),
         )
         # Exactly one job and one credential issuance for the reused key.
         assert h1.job_id == h2.job_id

tests/state/test_lease_expiry_grace.py

@@ -17,7 +17,7 @@
     RuntimeInfo,
     pair_memory_transports,
 )
-from arcp._messages.execution import LeaseConstraints as LC
+from arcp._messages.execution import LeaseConstraints as LeaseConstraintsMsg
 from arcp._runtime.lease import LeaseOpContext, validate_lease_op
 from arcp.client import ARCPClient
 from arcp.runtime import ARCPRuntime, StaticBearerVerifier
@@ -27,7 +27,7 @@ def test_expiry_grace_window_is_applied_and_configurable() -> None:
     now = dt.datetime.now(dt.UTC)
     # expires_at 0.5s in the past relative to `now`.
     expires = (now - dt.timedelta(seconds=0.5)).isoformat().replace("+00:00", "Z")
-    constraints = LC(expires_at=expires)
+    constraints = LeaseConstraintsMsg(expires_at=expires)
     lease = {"fs.read": ["*"]}
     ctx = LeaseOpContext(capability="fs.read", target="f", now=now)
 

tests/state/test_list_jobs_filters.py

@@ -285,9 +285,9 @@ async def slow_agent(input_value, ctx):
         id=new_envelope_id(),
         type="session.list_jobs",
         session_id=welcome.session_id,
-        payload=SessionListJobsPayload(
-            filter=ListJobsFilter(created_after=naive_past)
-        ).model_dump(mode="json", exclude_none=True),
+        payload=SessionListJobsPayload(filter=ListJobsFilter(created_after=naive_past)).model_dump(
+            mode="json", exclude_none=True
+        ),
     )
     # Must not raise (previously: TypeError → INTERNAL_ERROR).
     await handle_list_jobs(rt, ctx, env)

tests/state/test_resume_rebind_jobs.py

@@ -62,9 +62,9 @@ async def agent(input_value, ctx):
         async for e in rt.event_log.read_since_seq(welcome.session_id, 1)
         if e.get("job_id") == job_id
     ]
-    assert any(
-        e["payload"].get("body", {}).get("message") == "e1" for e in logged
-    ), f"window event e1 not persisted: {logged}"
+    assert any(e["payload"].get("body", {}).get("message") == "e1" for e in logged), (
+        f"window event e1 not persisted: {logged}"
+    )
 
     # --- connection 2: resume ----------------------------------------------
     server_b, client_b = pair_memory_transports()
@@ -104,7 +104,8 @@ async def spy(env: Envelope) -> None:
 
         # The seqs B observes are strictly increasing (no collision/gap).
         seqs = [s for _, s, _ in seen if s is not None]
-        assert seqs == sorted(seqs) and len(seqs) == len(set(seqs)), seqs
+        assert seqs == sorted(seqs), seqs
+        assert len(seqs) == len(set(seqs)), seqs
     finally:
         for c in (a, b):
             with contextlib.suppress(Exception):

tests/state/test_subscriber_seq_coherent.py

@@ -4,6 +4,7 @@
 
 import asyncio
 import contextlib
+from itertools import pairwise
 
 from arcp import (
     Capabilities,
@@ -33,7 +34,7 @@ def _assert_monotonic_gapfree(seqs: list[int]) -> None:
     assert seqs == sorted(seqs), f"not monotonic: {seqs}"
     assert len(seqs) == len(set(seqs)), f"duplicate seq: {seqs}"
     # gap-free: consecutive values differ by exactly 1.
-    for a, b in zip(seqs, seqs[1:], strict=False):
+    for a, b in pairwise(seqs):
         assert b == a + 1, f"gap in seq stream: {seqs}"
 
 

tests/unit/test_lease_glob.py

@@ -67,7 +67,10 @@ def test_single_star_child_is_subset_of_globstar_parent() -> None:
 
 
 def test_model_use_child_outside_parent_set_rejected() -> None:
-    assert is_lease_subset({"model.use": ["tier-fast/*-preview/*"]}, {"model.use": ["tier-fast/*"]}) is False
+    assert (
+        is_lease_subset({"model.use": ["tier-fast/*-preview/*"]}, {"model.use": ["tier-fast/*"]})
+        is False
+    )
     assert is_lease_subset({"model.use": ["anthropic/*"]}, {"model.use": ["tier-fast/*"]}) is False