fix(@schematics/angular): correct error and warning messages in environments schematic

The error for non-application projects concatenated the first sentence with the
project type before evaluating the ternary, so the "Only application project
types are supported" sentence was never printed and projects without a
`projectType` were reported as having a "projectType" of "undefined". The
third-party `server` builder warning also printed the `build` target's builder
instead of the `server` target's builder.

Wrap the ternary in parentheses, use the `server` target's builder in the
warning, and fix the typos in both error messages.

Author: MeAkib

packages/schematics/angular/environments/index.ts

@@ -19,16 +19,17 @@ export default function (options: EnvironmentOptions): Rule {
   return updateWorkspace((workspace) => {
     const project = workspace.projects.get(options.project);
     if (!project) {
-      throw new SchematicsException(`Project name "${options.project}" doesn't not exist.`);
+      throw new SchematicsException(`Project name "${options.project}" does not exist.`);
     }
 
     const type = project.extensions['projectType'];
     if (type !== 'application') {
       return log(
         'error',
-        'Only application project types are support by this schematic.' + type
-          ? ` Project "${options.project}" has a "projectType" of "${type}".`
-          : ` Project "${options.project}" has no "projectType" defined.`,
+        'Only application project types are supported by this schematic.' +
+          (type
+            ? ` Project "${options.project}" has a "projectType" of "${type}".`
+            : ` Project "${options.project}" has no "projectType" defined.`),
       );
     }
 
@@ -89,7 +90,7 @@ function* generateConfigurationEnvironments(
   if (serverTarget && serverTarget.builder !== AngularBuilder.Server) {
     yield log(
       'warn',
-      `"server" target found for project "${projectName}" has a third-party builder "${buildTarget.builder}".` +
+      `"server" target found for project "${projectName}" has a third-party builder "${serverTarget.builder}".` +
         ' The generated project options may not be compatible with this builder.',
     );
   }

packages/schematics/angular/environments/index_spec.ts

@@ -192,4 +192,48 @@ describe('Environments Schematic', () => {
       }),
     );
   });
+
+  it('should log an error for non-application projects', async () => {
+    const config = JSON.parse(applicationTree.readContent('/angular.json'));
+    config.projects.foo.projectType = 'library';
+    applicationTree.overwrite('/angular.json', JSON.stringify(config, undefined, 2));
+
+    const logs: string[] = [];
+    const loggerSubscription = schematicRunner.logger.subscribe(({ message }) =>
+      logs.push(message),
+    );
+
+    try {
+      await runEnvironmentsSchematic();
+    } finally {
+      loggerSubscription.unsubscribe();
+    }
+
+    expect(logs).toEqual([
+      'Only application project types are supported by this schematic.' +
+        ' Project "foo" has a "projectType" of "library".',
+    ]);
+  });
+
+  it('should log the builder of a third-party server target', async () => {
+    const config = JSON.parse(applicationTree.readContent('/angular.json'));
+    config.projects.foo.architect.server = { builder: 'custom:server' };
+    applicationTree.overwrite('/angular.json', JSON.stringify(config, undefined, 2));
+
+    const logs: string[] = [];
+    const loggerSubscription = schematicRunner.logger.subscribe(({ message }) =>
+      logs.push(message),
+    );
+
+    try {
+      await runEnvironmentsSchematic();
+    } finally {
+      loggerSubscription.unsubscribe();
+    }
+
+    expect(logs).toContain(
+      '"server" target found for project "foo" has a third-party builder "custom:server".' +
+        ' The generated project options may not be compatible with this builder.',
+    );
+  });
 });