fixup! fix(@angular/build): validate library outputPath and avoid duplicate secondary README assets

Author: alan-agius4

packages/angular/build/src/builders/library/options.ts

@@ -13,7 +13,7 @@ import { supportColor } from '../../utils/color';
 import { assertIsError } from '../../utils/error';
 import { normalizeAssetPatterns } from '../../utils/normalize-asset-patterns';
 import { normalizeCacheOptions } from '../../utils/normalize-cache';
-import { canonicalizePath, isSubDirectory, toPosixPath } from '../../utils/path';
+import { canonicalizePath, toPosixPath } from '../../utils/path';
 import {
   generateSearchDirectories,
   getTailwindConfig,
@@ -47,7 +47,6 @@ export async function normalizeLibraryOptions(
 
   const {
     tsConfig,
-    outputPath: rawOutputPath,
     assets: rawAssets,
     stylePreprocessorOptions,
     inlineStyleLanguage = 'css',
@@ -63,19 +62,6 @@ export async function normalizeLibraryOptions(
     clearScreen,
   } = options;
 
-  const outputPath = toPosixPath(
-    path.resolve(workspaceRoot, rawOutputPath ?? path.posix.join('dist', projectName)),
-  );
-  if (
-    outputPath === workspaceRoot ||
-    outputPath === projectRoot ||
-    isSubDirectory(outputPath, projectRoot)
-  ) {
-    throw new Error(
-      `The 'outputPath' option ('${outputPath}') cannot be the workspace root, project root, or a parent directory of the project root.`,
-    );
-  }
-
   const resolvedTsConfigPath = toPosixPath(path.resolve(workspaceRoot, tsConfig));
   const packageJsonPath = path.posix.join(projectRoot, 'package.json');
 
@@ -181,7 +167,9 @@ export async function normalizeLibraryOptions(
     projectRoot,
     packageName,
     packageJson,
-    outputPath,
+    outputPath: toPosixPath(
+      path.resolve(workspaceRoot, options.outputPath ?? path.posix.join('dist', projectName)),
+    ),
     deleteOutputPath,
     packageJsonPath,
     tsConfigPath: resolvedTsConfigPath,

packages/angular/build/src/builders/library/tests/options/output-path_spec.ts

@@ -32,58 +32,5 @@ describeLibraryBuilder(executeLibraryBuilder, LIBRARY_BUILDER_INFO, (harness) =>
       harness.expectFile('dist/custom-output/fesm2022/lib.mjs').toExist();
       harness.expectFile('dist/custom-output/package.json').toExist();
     });
-
-    it('should reject outputPath equal to projectRoot', async () => {
-      harness.useTarget('build', {
-        ...BASE_OPTIONS,
-        outputPath: 'projects/lib',
-      });
-
-      const { result, error } = await harness.executeOnce({
-        outputLogsOnException: false,
-        outputLogsOnFailure: false,
-      });
-      expect(result).toBeUndefined();
-      expect(error).toBeDefined();
-      expect((error as Error).message).toMatch(
-        /The 'outputPath' option .* cannot be the workspace root, project root, or a parent directory of the project root/,
-      );
-      harness.expectFile('projects/lib/package.json').toExist();
-    });
-
-    it('should reject outputPath equal to workspaceRoot', async () => {
-      harness.useTarget('build', {
-        ...BASE_OPTIONS,
-        outputPath: '.',
-      });
-
-      const { result, error } = await harness.executeOnce({
-        outputLogsOnException: false,
-        outputLogsOnFailure: false,
-      });
-      expect(result).toBeUndefined();
-      expect(error).toBeDefined();
-      expect((error as Error).message).toMatch(
-        /The 'outputPath' option .* cannot be the workspace root, project root, or a parent directory of the project root/,
-      );
-    });
-
-    it('should reject outputPath when it is a parent directory of projectRoot', async () => {
-      harness.useTarget('build', {
-        ...BASE_OPTIONS,
-        outputPath: 'projects',
-      });
-
-      const { result, error } = await harness.executeOnce({
-        outputLogsOnException: false,
-        outputLogsOnFailure: false,
-      });
-      expect(result).toBeUndefined();
-      expect(error).toBeDefined();
-      expect((error as Error).message).toMatch(
-        /The 'outputPath' option .* cannot be the workspace root, project root, or a parent directory of the project root/,
-      );
-      harness.expectFile('projects/lib/package.json').toExist();
-    });
   });
 });