fixup! refactor(@angular/build): normalize library builder paths to POSIX format

Author: alan-agius4

packages/angular/build/src/utils/delete-output-dir.ts

@@ -17,8 +17,9 @@ export async function deleteOutputDir(
   outputPath: string,
   emptyOnlyDirectories?: string[],
 ): Promise<void> {
-  const resolvedOutputPath = resolve(root, outputPath);
-  if (resolvedOutputPath === root) {
+  const resolvedRoot = resolve(root);
+  const resolvedOutputPath = resolve(resolvedRoot, outputPath);
+  if (resolvedOutputPath === resolvedRoot) {
     throw new Error('Output path MUST not be project root directory!');
   }
 

packages/angular/build/src/utils/normalize-asset-patterns.ts

@@ -24,23 +24,24 @@ export function normalizeAssetPatterns(
 
   // When sourceRoot is not available, we default to ${projectRoot}/src.
   const sourceRoot = projectSourceRoot || path.join(projectRoot, 'src');
-  const resolvedSourceRoot = path.resolve(workspaceRoot, sourceRoot);
-  const resolvedProjectRoot = path.resolve(workspaceRoot, projectRoot);
+  const resolvedWorkspaceRoot = path.resolve(workspaceRoot);
+  const resolvedSourceRoot = path.resolve(resolvedWorkspaceRoot, sourceRoot);
+  const resolvedProjectRoot = path.resolve(resolvedWorkspaceRoot, projectRoot);
 
   return assetPatterns.map((assetPattern) => {
     // Normalize string asset patterns to objects.
     if (typeof assetPattern === 'string') {
       const assetPath = path.normalize(assetPattern);
-      const resolvedAssetPath = path.resolve(workspaceRoot, assetPath);
+      const resolvedAssetPath = path.resolve(resolvedWorkspaceRoot, assetPath);
       let root: string;
 
       // Check if the string asset is within sourceRoot.
       if (resolvedAssetPath.startsWith(resolvedSourceRoot)) {
         root = resolvedSourceRoot;
       } else if (resolvedAssetPath.startsWith(resolvedProjectRoot)) {
         root = resolvedProjectRoot;
-      } else if (resolvedAssetPath.startsWith(workspaceRoot)) {
-        root = workspaceRoot;
+      } else if (resolvedAssetPath.startsWith(resolvedWorkspaceRoot)) {
+        root = resolvedWorkspaceRoot;
       } else {
         throw new Error(`The ${assetPattern} asset path must be within the workspace root.`);
       }
@@ -67,11 +68,11 @@ export function normalizeAssetPatterns(
       }
 
       // Output directory for both is the relative path from the root to input.
-      const output = path.relative(root, path.resolve(workspaceRoot, input));
+      const output = path.relative(root, path.resolve(resolvedWorkspaceRoot, input));
 
       assetPattern = { glob, input, output };
     } else {
-      if (!isSubDirectory(workspaceRoot, assetPattern.input)) {
+      if (!isSubDirectory(resolvedWorkspaceRoot, assetPattern.input)) {
         throw new Error(`The ${assetPattern.input} asset path must be within the workspace root.`);
       }