fixup! perf(@angular/build): avoid TS AST eviction and d.ts re-emit on external resource edits

Author: alan-agius4

packages/angular/build/src/builders/library/tests/behavior/watch_spec.ts

@@ -848,20 +848,23 @@ describeLibraryBuilder(executeLibraryBuilder, LIBRARY_BUILDER_INFO, (harness) =>
       ]);
     });
 
-    it('should rebuild when an external Sass stylesheet or imported partial is modified', async () => {
+    it('should rebuild when an external Sass partial or template is modified and recover from template errors', async () => {
       await harness.writeFiles({
         'projects/lib/src/lib/_vars.scss': '$primary-color: rgb(10, 20, 30);',
         'projects/lib/src/lib/lib.component.scss':
-          '@use "./vars"; :host { color: vars.$primary-color; padding: 4px; }',
+          '@use "./vars"; :host { color: vars.$primary-color; }',
+        'projects/lib/src/lib/lib.component.html': '<h1>{{ title }}</h1>',
         'projects/lib/src/lib/lib.component.ts': `
           import { Component } from '@angular/core';
 
           @Component({
-            selector: 'lib-external-sass',
-            template: '<span>External Sass</span>',
+            selector: 'lib-external-resources',
+            templateUrl: './lib.component.html',
             styleUrl: './lib.component.scss',
           })
-          export class LibComponent {}
+          export class LibComponent {
+            title = 'Hello';
+          }
         `,
       });
 
@@ -874,85 +877,21 @@ describeLibraryBuilder(executeLibraryBuilder, LIBRARY_BUILDER_INFO, (harness) =>
         async ({ result }) => {
           expect(result?.success).toBeTrue();
           const content = harness.readFile('dist/lib/fesm2022/lib.mjs');
+          expect(content).toContain('h1');
           expect(content).toMatch(/color:\s*(?:#0a141e|rgb\(10,\s*20,\s*30\))/);
-          expect(content).toMatch(/padding:\s*4px/);
           expect(harness.readFile('dist/lib/types/lib.d.ts')).toContain('LibComponent');
 
-          // Modify the external component stylesheet directly
-          await harness.writeFile(
-            'projects/lib/src/lib/lib.component.scss',
-            '@use "./vars"; :host { color: vars.$primary-color; padding: 16px; }',
-          );
-        },
-        async ({ result, logs }) => {
-          expect(result?.success).toBeTrue();
-          const content = harness.readFile('dist/lib/fesm2022/lib.mjs');
-          expect(content).toMatch(/color:\s*(?:#0a141e|rgb\(10,\s*20,\s*30\))/);
-          expect(content).toMatch(/padding:\s*16px/);
-          expect(harness.readFile('dist/lib/types/lib.d.ts')).toContain('LibComponent');
-          expect(logs).toContain(
-            jasmine.objectContaining({
-              message: jasmine.stringContaining('Compiling lib...'),
-            }),
-          );
-
           // Modify the imported Sass partial
           await harness.writeFile(
             'projects/lib/src/lib/_vars.scss',
             '$primary-color: rgb(200, 100, 50);',
           );
         },
-        ({ result, logs }) => {
-          expect(result?.success).toBeTrue();
-          const content = harness.readFile('dist/lib/fesm2022/lib.mjs');
-          expect(content).toMatch(/color:\s*(?:#c86432|rgb\(200,\s*100,\s*50\))/);
-          expect(content).toMatch(/padding:\s*16px/);
-          expect(harness.readFile('dist/lib/types/lib.d.ts')).toContain('LibComponent');
-          expect(logs).toContain(
-            jasmine.objectContaining({
-              message: jasmine.stringContaining('Compiling lib...'),
-            }),
-          );
-        },
-      ]);
-    });
-
-    it('should report template errors and recover when an external template is modified', async () => {
-      await harness.writeFiles({
-        'projects/lib/src/lib/lib.component.html': '<h1>{{ title }}</h1>',
-        'projects/lib/src/lib/lib.component.ts': `
-          import { Component } from '@angular/core';
-
-          @Component({
-            selector: 'lib-external-template',
-            templateUrl: './lib.component.html',
-          })
-          export class LibComponent {
-            title = 'Hello';
-          }
-        `,
-      });
-
-      harness.useTarget('build', {
-        ...BASE_OPTIONS,
-        watch: true,
-      });
-
-      await harness.executeWithCases([
         async ({ result }) => {
           expect(result?.success).toBeTrue();
-          expect(harness.readFile('dist/lib/fesm2022/lib.mjs')).toContain('h1');
-          expect(harness.readFile('dist/lib/types/lib.d.ts')).toContain('LibComponent');
-
-          // Modify external HTML template with valid markup
-          await harness.writeFile(
-            'projects/lib/src/lib/lib.component.html',
-            '<section>{{ title }}</section>',
+          expect(harness.readFile('dist/lib/fesm2022/lib.mjs')).toMatch(
+            /color:\s*(?:#c86432|rgb\(200,\s*100,\s*50\))/,
           );
-        },
-        async ({ result }) => {
-          expect(result?.success).toBeTrue();
-          expect(harness.readFile('dist/lib/fesm2022/lib.mjs')).toContain('section');
           expect(harness.readFile('dist/lib/types/lib.d.ts')).toContain('LibComponent');
 
           // Introduce a template type-checking error in the external HTML template