fix(@angular/ssr): abort web request signal when node request is aborted

Author: alan-agius4

packages/angular/ssr/node/src/request.ts

@@ -55,9 +55,12 @@ export function createWebRequestFromNodeRequest(
   const { headers, method = 'GET' } = nodeRequest;
   const withBody = method !== 'GET' && method !== 'HEAD';
   const referrer = headers.referer && URL.canParse(headers.referer) ? headers.referer : undefined;
+  const controller = new AbortController();
+  nodeRequest.once('aborted', () => controller.abort());
 
   return new Request(createRequestUrl(nodeRequest, trustProxyHeadersNormalized), {
     method,
+    signal: controller.signal,
     headers: createRequestHeaders(headers),
     body: withBody ? nodeRequest : undefined,
     duplex: withBody ? 'half' : undefined,

packages/angular/ssr/node/test/request_http1_spec.ts

@@ -189,4 +189,24 @@ describe('createWebRequestFromNodeRequest (HTTP/1.1)', () => {
       expect(await webRequest.text()).toBe('');
     });
   });
+
+  describe('abort handling', () => {
+    it('should abort the web request signal when the node request is aborted', async () => {
+      const nodeRequest = await extractNodeRequest(() => {
+        request({
+          hostname: 'localhost',
+          port,
+          path: '/abort',
+          method: 'GET',
+        }).end();
+      });
+
+      const webRequest = createWebRequestFromNodeRequest(nodeRequest);
+      expect(webRequest.signal.aborted).toBeFalse();
+
+      nodeRequest.emit('aborted');
+
+      expect(webRequest.signal.aborted).toBeTrue();
+    });
+  });
 });

packages/angular/ssr/node/test/request_http2_spec.ts

@@ -188,4 +188,24 @@ describe('createWebRequestFromNodeRequest (HTTP/2)', () => {
       expect(await webRequest.text()).toBe('');
     });
   });
+
+  describe('abort handling', () => {
+    it('should abort the web request signal when the node request is aborted', async () => {
+      const nodeRequest = await extractNodeRequest(() => {
+        client
+          .request({
+            ':path': '/abort',
+            ':method': 'GET',
+          })
+          .end();
+      });
+
+      const webRequest = createWebRequestFromNodeRequest(nodeRequest);
+      expect(webRequest.signal.aborted).toBeFalse();
+
+      nodeRequest.emit('aborted');
+
+      expect(webRequest.signal.aborted).toBeTrue();
+    });
+  });
 });