GH-1027: Move port validation to NettyClientBuilder.build()

Validate the port synchronously in NettyClientBuilder.build() before
calling forAddress(String, int), restoring the fail-fast behaviour that
was lost when switching away from forAddress(SocketAddress). Placing
the check here protects all callers (not just JDBC), and the resulting
IllegalArgumentException is already caught and wrapped as SQLException
by ArrowFlightSqlClientHandler.Builder.build().

Reverts the validation that was previously added to
ArrowFlightConnectionConfigImpl.getPort() and the associated
throws-SQLException ripple across FlightServerTestExtension,
OAuthIntegrationTest, and ArrowFlightConnectionConfigImplTest.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: ennuite

flight/flight-core/src/main/java/org/apache/arrow/flight/grpc/NettyClientBuilder.java

@@ -139,9 +139,12 @@ public NettyChannelBuilder build() {
       case LocationSchemes.GRPC_INSECURE:
       case LocationSchemes.GRPC_TLS:
         {
-          builder =
-              NettyChannelBuilder.forAddress(
-                  location.getUri().getHost(), location.getUri().getPort());
+          final int port = location.getUri().getPort();
+          if (port < 1 || port > 65535) {
+            throw new IllegalArgumentException(
+                "Invalid port " + port + ": must be between 1 and 65535.");
+          }
+          builder = NettyChannelBuilder.forAddress(location.getUri().getHost(), port);
           break;
         }
       case LocationSchemes.GRPC_DOMAIN_SOCKET:

flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/utils/ArrowFlightConnectionConfigImpl.java

@@ -55,12 +55,8 @@ public String getHost() {
    *
    * @return the port.
    */
-  public int getPort() throws SQLException {
-    final int port = ArrowFlightConnectionProperty.PORT.getInteger(properties);
-    if (port < 1 || port > 65535) {
-      throw new SQLException("Invalid port " + port + ": must be between 1 and 65535.");
-    }
-    return port;
+  public int getPort() {
+    return ArrowFlightConnectionProperty.PORT.getInteger(properties);
   }
 
   /**

flight/flight-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc/FlightServerTestExtension.java

@@ -211,7 +211,7 @@ private FlightServer getStartServer(
    *
    * @return the port value.
    */
-  public int getPort() throws SQLException {
+  public int getPort() {
     return config.getPort();
   }
 

flight/flight-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc/OAuthIntegrationTest.java

@@ -161,7 +161,7 @@ private void enqueueErrorResponse(String error, String description) {
             .build());
   }
 
-  private Properties createBaseProperties() throws SQLException {
+  private Properties createBaseProperties() {
     Properties props = new Properties();
     props.put(ArrowFlightConnectionProperty.HOST.camelName(), "localhost");
     props.put(
@@ -170,7 +170,7 @@ private Properties createBaseProperties() throws SQLException {
     return props;
   }
 
-  private String getJdbcUrl() throws SQLException {
+  private String getJdbcUrl() {
     return String.format(
         "jdbc:arrow-flight-sql://localhost:%d", FLIGHT_SERVER_TEST_EXTENSION.getPort());
   }
@@ -408,7 +408,7 @@ public void testTokenRefreshAfterExpiration() throws Exception {
   // ==================== Error Handling Tests ====================
 
   @Test
-  public void testMissingRequiredParametersClientCredentials() throws Exception {
+  public void testMissingRequiredParametersClientCredentials() {
     Properties props = createBaseProperties();
     props.put(ArrowFlightConnectionProperty.OAUTH_FLOW.camelName(), "client_credentials");
     props.put(ArrowFlightConnectionProperty.OAUTH_TOKEN_URI.camelName(), tokenEndpoint.toString());
@@ -418,7 +418,7 @@ public void testMissingRequiredParametersClientCredentials() throws Exception {
   }
 
   @Test
-  public void testMissingRequiredParametersTokenExchange() throws Exception {
+  public void testMissingRequiredParametersTokenExchange() {
     Properties props = createBaseProperties();
     props.put(ArrowFlightConnectionProperty.OAUTH_FLOW.camelName(), "token_exchange");
     props.put(ArrowFlightConnectionProperty.OAUTH_TOKEN_URI.camelName(), tokenEndpoint.toString());
@@ -428,7 +428,7 @@ public void testMissingRequiredParametersTokenExchange() throws Exception {
   }
 
   @Test
-  public void testInvalidOAuthFlow() throws Exception {
+  public void testInvalidOAuthFlow() {
     Properties props = createBaseProperties();
     props.put(ArrowFlightConnectionProperty.OAUTH_FLOW.camelName(), "invalid_flow");
     props.put(ArrowFlightConnectionProperty.OAUTH_TOKEN_URI.camelName(), tokenEndpoint.toString());
@@ -437,7 +437,7 @@ public void testInvalidOAuthFlow() throws Exception {
   }
 
   @Test
-  public void testMalformedTokenEndpoint() throws Exception {
+  public void testMalformedTokenEndpoint() {
     Properties props = createBaseProperties();
     props.put(ArrowFlightConnectionProperty.OAUTH_FLOW.camelName(), "client_credentials");
     props.put(ArrowFlightConnectionProperty.OAUTH_TOKEN_URI.camelName(), "not-a-valid-uri://");

flight/flight-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc/utils/ArrowFlightConnectionConfigImplTest.java

@@ -72,7 +72,7 @@ public void testGetProperty(
   }
 
   public static Stream<Arguments> provideParameters() {
-    int port = RANDOM.nextInt(65535) + 1;
+    int port = RANDOM.nextInt(Short.toUnsignedInt(Short.MAX_VALUE));
     boolean useEncryption = RANDOM.nextBoolean();
     int threadPoolSize = RANDOM.nextInt(getRuntime().availableProcessors());
     return Stream.of(
@@ -87,13 +87,7 @@ public static Stream<Arguments> provideParameters() {
             port,
             port,
             (Function<ArrowFlightConnectionConfigImpl, ?>)
-                config -> {
-                  try {
-                    return config.getPort();
-                  } catch (java.sql.SQLException e) {
-                    throw new RuntimeException(e);
-                  }
-                }),
+                ArrowFlightConnectionConfigImpl::getPort),
         Arguments.of(
             USER,
             "user",