Commit df0627d
authored
### What's Changed
The Flight SQL JDBC driver ignored JVM proxy settings
(`-Dhttps.proxyHost`, `-Dhttps.proxyPort`). Connections would always go
directly to the target host, bypassing any configured proxy.
Switched to `NettyChannelBuilder.forAddress(host, port)` for the
TCP-based schemes. This causes gRPC to go through `ProxySelector`, which
picks up the standard JVM proxy properties.
### Are these changes tested?
Yes.
Added a test to `ConnectionTest` that installs a recording
`ProxySelector` as the JVM default, opens a JDBC connection, and asserts
that `ProxySelector.select() `was called. This directly validates that
the driver participates in JVM proxy detection without requiring a real
proxy server.
This change was created with AI assistance (Claude Code). All lines were
manually reviewed by a human. The output is not copyrightable subject
matter.
Closes #577.
---------
Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 4e8faf7 commit df0627d
2 files changed
Lines changed: 48 additions & 1 deletion
File tree
- flight
- flight-core/src/main/java/org/apache/arrow/flight/grpc
- flight-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
142 | | - | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
143 | 148 | | |
144 | 149 | | |
145 | 150 | | |
| |||
Lines changed: 42 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
29 | 34 | | |
30 | 35 | | |
31 | 36 | | |
32 | 37 | | |
33 | 38 | | |
34 | 39 | | |
35 | 40 | | |
| 41 | + | |
36 | 42 | | |
37 | 43 | | |
| 44 | + | |
38 | 45 | | |
39 | 46 | | |
40 | 47 | | |
| |||
768 | 775 | | |
769 | 776 | | |
770 | 777 | | |
| 778 | + | |
| 779 | + | |
| 780 | + | |
| 781 | + | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
| 786 | + | |
| 787 | + | |
| 788 | + | |
| 789 | + | |
| 790 | + | |
| 791 | + | |
| 792 | + | |
| 793 | + | |
| 794 | + | |
| 795 | + | |
| 796 | + | |
| 797 | + | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
771 | 813 | | |
0 commit comments