From a58b6c276c330f84dedd05d083e400ecc23e8b54 Mon Sep 17 00:00:00 2001 From: Hiroyuki Sato Date: Thu, 6 Aug 2026 21:25:44 +0900 Subject: [PATCH] GH-50824: [R] Fix shellcheck errors in the r/tools/download_dependencies_R.sh --- .pre-commit-config.yaml | 1 + r/tools/download_dependencies_R.sh | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index a603390c82b1..fca235eea007 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -321,6 +321,7 @@ repos: ?^dev/release/setup-rhel-rebuilds\.sh$| ?^dev/release/utils-generate-checksum\.sh$| ?^dev/release/utils-watch-gh-workflow\.sh$| + ?^r/tools/download_dependencies_R\.sh$| ?^swift/gen-protobuffers\.sh$| ) - repo: https://github.com/scop/pre-commit-shfmt diff --git a/r/tools/download_dependencies_R.sh b/r/tools/download_dependencies_R.sh index 3e5f64614bd4..c5a0b96ca9a4 100755 --- a/r/tools/download_dependencies_R.sh +++ b/r/tools/download_dependencies_R.sh @@ -45,7 +45,7 @@ download_dependency() { local url=$1 local out=$2 - echo 'download.file("'${url}'", "'${out}'", quiet = TRUE)' + echo "download.file(\"${url}\", \"${out}\", quiet = TRUE)" } print_tar_name() { @@ -56,7 +56,7 @@ print_tar_name() { main() { # Load `DEPENDENCIES` variable. - source ${SOURCE_DIR}/cpp/thirdparty/versions.txt + source "${SOURCE_DIR}/cpp/thirdparty/versions.txt" for ((i = 0; i < ${#DEPENDENCIES[@]}; i++)); do local dep_packed=${DEPENDENCIES[$i]} @@ -65,7 +65,7 @@ main() { IFS=" " read -r dep_url_var dep_tar_name dep_url <<< "${dep_packed}" if [[ "$run_mode" == "download_dependency" ]]; then - local out=${DESTDIR}/${dep_tar_name} + local out="${DESTDIR}/${dep_tar_name}" download_dependency "${dep_url}" "${out}" elif [[ "$run_mode" == "print_tar_name" ]]; then print_tar_name "${dep_url_var}" "${dep_tar_name}"