From e6299eb4f09b893ff7659241a4b29b60ca11be6a Mon Sep 17 00:00:00 2001 From: nishad shabbir Date: Mon, 26 Oct 2026 23:45:55 +0530 Subject: [PATCH] GH-55161: [Dev] Remove the archery integration --with-all option --with-all stopped working in 22.0.0: GH-47650 (9a219256bf) removed the loop in integration() that implemented it when select_testers() took over, so the flag has been accepted and ignored since then. Nothing in the repository passes it. CI goes through ARCHERY_INTEGRATION_WITH_*, and verify-release-candidate.sh and generate_files_for_endian_test.sh pass explicit --with- flags, so remove the option rather than restore it. docs/source/format/Integration.rst was the one place still telling contributors to use it, so rewrite that example to enable each implementation explicitly, matching the two examples above it. --- dev/archery/archery/cli.py | 5 +---- docs/source/format/Integration.rst | 7 +++++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dev/archery/archery/cli.py b/dev/archery/archery/cli.py index e7dcc819500f..a52543406a33 100644 --- a/dev/archery/archery/cli.py +++ b/dev/archery/archery/cli.py @@ -707,9 +707,6 @@ def _set_default(opt, default): @archery.command(short_help="Execute protocol and Flight integration tests") -@click.option('--with-all', is_flag=True, default=False, - help=('Include all known implementations by default ' - 'in integration tests')) @click.option('--random-seed', type=int, default=12345, help="Seed for PRNG when generating test data") @click.option('--with-cpp', type=bool, default=False, @@ -764,7 +761,7 @@ def _set_default(opt, default): @click.option('-k', '--match', help=("Substring for test names to include in run, " "e.g. -k primitive")) -def integration(with_all=False, random_seed=12345, write_generated_json="", +def integration(random_seed=12345, write_generated_json="", write_gold_files="", **args): """If you don't specify the "--target-implementations" option nor the "ARCHERY_INTEGRATION_TARGET_IMPLEMENTATIONS" environment diff --git a/docs/source/format/Integration.rst b/docs/source/format/Integration.rst index 5038132241c3..fe7aeae15ef3 100644 --- a/docs/source/format/Integration.rst +++ b/docs/source/format/Integration.rst @@ -137,11 +137,14 @@ For Java, it may look like: export ARROW_JAVA_INTEGRATION_JAR=$JAVA_DIR/tools/target/arrow-tools-$VERSION-jar-with-dependencies.jar archery integration --run-ipc --with-cpp=1 --with-java=1 -To run all tests, including Flight and C Data Interface integration tests, do: +To run all tests, including Flight and C Data Interface integration tests, +enable each implementation explicitly: .. code-block:: shell - archery integration --with-all --run-flight --run-ipc --run-c-data + archery integration --run-flight --run-ipc --run-c-data \ + --with-cpp=1 --with-dotnet=1 --with-go=1 --with-java=1 \ + --with-js=1 --with-nanoarrow=1 --with-ruby=1 --with-rust=1 Note that we run these tests in continuous integration, and the CI job uses Docker Compose. You may also run the Docker Compose job locally, or at least