Skip to content

Fix git hooks in cassandra builds where core.symlinks is false #4866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frankgh wants to merge 1 commit into
base: trunk
Choose a base branch
from
+11 −1
Open

Fix git hooks in cassandra builds where core.symlinks is false #4866

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .build/git/install-git-defaults.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,18 @@ install_hook() {
installed=false
fi
fi
# Resolve the source hooks directory. When git is configured with
# core.symlinks=false (e.g. for security reasons, or on filesystems that
# don't support symlinks), a symlinked hooks dir such as post-switch is
# checked out as a plain text file whose contents are the link target.
# Follow that indirection so the build works regardless of core.symlinks.
local src_dir="$bin/git-hooks/${name}"
while [[ -f "$src_dir" ]]; do
src_dir="$(dirname "$src_dir")/$(cat "$src_dir")"
done

# install all hooks
cp "$bin"/git-hooks/"${name}"/* "$d_dir"/
cp "$src_dir"/* "$d_dir"/

# install coordinator hook
install_template_script "$script_name" "$d_dir"
Expand Down