Skip to content

Commit 35f8ee7

Browse files
author
Pearl Dsilva
committed
remove unnecessary stubbings
1 parent f14f9dd commit 35f8ee7

1 file changed

Lines changed: 0 additions & 10 deletions

File tree

server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3219,12 +3219,10 @@ public void testValidateStorageAccessGroupsOnHostsVolumeBasedSuccessWithMatching
32193219
Mockito.when(volume1.getPoolId()).thenReturn(100L);
32203220
Mockito.when(volume1.getName()).thenReturn("volume1");
32213221
Mockito.when(volume1.getVolumeType()).thenReturn(Volume.Type.ROOT);
3222-
Mockito.when(storagePool1.getName()).thenReturn("pool1");
32233222

32243223
Mockito.when(volume2.getPoolId()).thenReturn(200L);
32253224
Mockito.when(volume2.getName()).thenReturn("volume2");
32263225
Mockito.when(volume2.getVolumeType()).thenReturn(Volume.Type.DATADISK);
3227-
Mockito.when(storagePool2.getName()).thenReturn("pool2");
32283226

32293227
Mockito.when(volumeDaoMock.findByInstance(1L)).thenReturn(vmVolumes);
32303228

@@ -3261,7 +3259,6 @@ public void testValidateStorageAccessGroupsOnHostsVolumeBasedSuccessWithIntersec
32613259
Mockito.when(volume1.getPoolId()).thenReturn(100L);
32623260
Mockito.when(volume1.getName()).thenReturn("volume1");
32633261
Mockito.when(volume1.getVolumeType()).thenReturn(Volume.Type.ROOT);
3264-
Mockito.when(storagePool1.getName()).thenReturn("pool1");
32653262

32663263
Mockito.when(volumeDaoMock.findByInstance(1L)).thenReturn(vmVolumes);
32673264

@@ -3287,12 +3284,9 @@ public void testValidateStorageAccessGroupsOnHostsSuccessWithEmptyStorageGroups(
32873284

32883285
Mockito.when(vm.getId()).thenReturn(1L);
32893286
Mockito.when(destinationHost.getId()).thenReturn(2L);
3290-
Mockito.when(destinationHost.getName()).thenReturn("destHost");
32913287

32923288
Mockito.when(volume1.getPoolId()).thenReturn(100L);
32933289
Mockito.when(volume1.getName()).thenReturn("volume1");
3294-
Mockito.when(volume1.getVolumeType()).thenReturn(Volume.Type.ROOT);
3295-
Mockito.when(storagePool1.getName()).thenReturn("pool1");
32963290

32973291
Mockito.when(volumeDaoMock.findByInstance(1L)).thenReturn(vmVolumes);
32983292

@@ -3321,7 +3315,6 @@ public void testValidateStorageAccessGroupsOnHostsDestinationHostEmptyGroups() {
33213315
Mockito.when(volume1.getPoolId()).thenReturn(100L);
33223316
Mockito.when(volume1.getName()).thenReturn("volume1");
33233317
Mockito.when(volume1.getVolumeType()).thenReturn(Volume.Type.ROOT);
3324-
Mockito.when(storagePool1.getName()).thenReturn("pool1");
33253318

33263319
Mockito.when(volumeDaoMock.findByInstance(1L)).thenReturn(vmVolumes);
33273320
Mockito.when(storageManager.getStorageAccessGroups(null, null, null, 2L))
@@ -3350,7 +3343,6 @@ public void testValidateStorageAccessGroupsOnHostsFailureNoMatch() {
33503343
Mockito.when(volume1.getPoolId()).thenReturn(100L);
33513344
Mockito.when(volume1.getName()).thenReturn("volume1");
33523345
Mockito.when(volume1.getVolumeType()).thenReturn(Volume.Type.ROOT);
3353-
Mockito.when(storagePool1.getName()).thenReturn("pool1");
33543346

33553347
Mockito.when(volumeDaoMock.findByInstance(1L)).thenReturn(vmVolumes);
33563348

@@ -3382,12 +3374,10 @@ public void testValidateStorageAccessGroupsOnHostsMultipleVolumesFailure() {
33823374
Mockito.when(volume1.getPoolId()).thenReturn(100L);
33833375
Mockito.when(volume1.getName()).thenReturn("volume1");
33843376
Mockito.when(volume1.getVolumeType()).thenReturn(Volume.Type.ROOT);
3385-
Mockito.when(storagePool1.getName()).thenReturn("pool1");
33863377

33873378
Mockito.when(volume2.getPoolId()).thenReturn(200L);
33883379
Mockito.when(volume2.getName()).thenReturn("volume2");
33893380
Mockito.when(volume2.getVolumeType()).thenReturn(Volume.Type.DATADISK);
3390-
Mockito.when(storagePool2.getName()).thenReturn("pool2");
33913381

33923382
Mockito.when(volumeDaoMock.findByInstance(1L)).thenReturn(vmVolumes);
33933383

0 commit comments

Comments
 (0)