CSTACKEX-209: updating allowed snapshot name size to 255 as per the cloudstack and ontap supported scenarios

Author: rajiv-jain-netapp

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/utils/OntapStorageConstants.java

@@ -104,7 +104,7 @@ public class OntapStorageConstants {
     public static final String PRIMARY_POOL_ID = "primary_pool_id";
     public static final String ONTAP_SNAP_SIZE = "ontap_snap_size";
     public static final String FILE_PATH = "file_path";
-    public static final int MAX_SNAPSHOT_NAME_LENGTH = 64;
+    public static final int MAX_SNAPSHOT_NAME_LENGTH = 255;
 
     /** vm_snapshot_details key for ONTAP FlexVolume-level VM snapshots. */
     public static final String ONTAP_FLEXVOL_SNAPSHOT = "ontapFlexVolSnapshot";

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/vmsnapshot/OntapVMSnapshotStrategy.java

@@ -673,7 +673,7 @@ Map<String, FlexVolGroupInfo> groupVolumesByFlexVol(List<VolumeObjectTO> volumeT
      */
     String buildSnapshotName(VMSnapshot vmSnapshot) {
         String name = "vmsnap_" + vmSnapshot.getId() + "_" + System.currentTimeMillis();
-        // ONTAP snapshot names: max 256 chars, must start with letter, only alphanumeric and underscores
+        // ONTAP snapshot names: max 255 chars, must start with letter, only alphanumeric and underscores
         if (name.length() > OntapStorageConstants.MAX_SNAPSHOT_NAME_LENGTH) {
             name = name.substring(0, OntapStorageConstants.MAX_SNAPSHOT_NAME_LENGTH);
         }