Skip to content

Commit cdbed60

Browse files
Apply suggestions from code review
Co-authored-by: Abhishek Kumar <abhishek.mrt22@gmail.com> Co-authored-by: dahn <daan.hoogland@gmail.com>
1 parent dcf3cfe commit cdbed60

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

draft-THREAT-MODEL.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ private/public cloud control plane", not a hosted-as-a-service appliance.
9090

9191
- A multi-tenant IaaS control plane deployed by an operator inside a
9292
controlled datacenter or cloud, exposing compute / storage / network
93-
orchestration to authenticated end users via a JSON API and a Vue.js Web
93+
orchestration to authenticated end users via APIs which return responses in JSON or XML and a Vue.js Web
9494
UI, with separately authenticated administrators *(documented: `README.md`,
9595
`INSTALL.md`)*.
9696
- Used both for service-provider public clouds and for on-premises private
@@ -134,7 +134,7 @@ single-instance is also a supported topology)*.
134134

135135
| Family | Representative entry point | Touches outside the process? | In-model? |
136136
| --- | --- | --- | --- |
137-
| Management server JSON API | `client/.../ApiServlet`, HTTPS on `:8080` (admin), `:8080/client/api` (user), HTTPS on `:8443` integration port *(documented: `server/src/main/java/com/cloud/api/ApiServlet.java`, `client/`)* | network (TCP, optionally TLS) | **yes** |
137+
| Management server JSON and XML APIs | `client/.../ApiServlet`, HTTPS on `:8080` (admin), `:8080/client/api` (user), HTTPS on `:8443` integration port *(documented: `server/src/main/java/com/cloud/api/ApiServlet.java`, `client/`)* | network (TCP, optionally TLS) | **yes** |
138138
| Management server Web UI | Vue.js SPA under `ui/`, served by the same servlet container *(documented: `ui/`)* | network | **yes** (auth is the API auth) |
139139
| Management server cluster RPC (peer-to-peer) | NIO + TLS between management-server replicas, `:9090` *(documented: `framework/cluster/`, `utils/.../nio/`)* | network | **yes** (peer auth via Root CA) |
140140
| Management server → agent RPC | NIO + TLS on `:8250` (default `agent.properties`) *(documented: `agent/conf/agent.properties` line 47, `utils/.../nio/NioServer.java`)* | network | **yes** (mutually authenticated via Root CA) |
@@ -199,7 +199,7 @@ requiring any of these will be closed with the cited disposition:
199199
resource-limit case.
200200
6. **A sandbox for templates, ISO images, or user-data scripts.** A
201201
user-uploaded template (via `registerTemplate`) is run by the
202-
hypervisor with the privileges the offering grants. cloud-init /
202+
hypervisor with the privileges the system grants. cloud-init /
203203
user-data / metadata is passed through to the guest; CloudStack does
204204
not parse or sanitize its semantics *(documented: kubernetes-service
205205
plugin `userdata` references; maintainer: vishesh92 — §14 Q10, end-user guest customization)*. →
@@ -337,8 +337,7 @@ follows:
337337

338338
## §5a Build-time and configuration variants
339339

340-
CloudStack ships as a family of `cloudstack-management`, `cloudstack-agent`,
341-
`cloudstack-usage`, `cloudstack-cli`, `cloudstack-ui` packages
340+
CloudStack ships as a family of packages: 'cloudstack-agent', 'cloudstack-baremetal-agent', 'cloudstack-common', 'cloudstack-integration-tests', 'cloudstack-management', 'cloudstack-marvin', 'cloudstack-mysql-ha', 'cloudstack-ui', 'cloudstack-usage'
342341
*(documented: `debian/`, `packaging/`)*. A sizable number of runtime
343342
configuration knobs materially change the security envelope. The
344343
security-relevant subset:

0 commit comments

Comments
 (0)