Skip to content

Commit d0984d7

Browse files
author
James Peru
committed
NAS backup: say the bandwidth limit counts virtual disk size
Lab run on libvirt 10.0.0 / QEMU 8.2.2 showed that a 4 GiB sparse disk with 172 MiB allocated still takes virtual size / limit when throttled with virsh blockjob --bandwidth, so the setting description now says so.
1 parent 3586cf2 commit d0984d7

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎plugins/backup/nas/src/main/java/org/apache/cloudstack/backup/NASBackupProvider.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ public class NASBackupProvider extends AdapterBase implements BackupProvider, Co
137137
ConfigKey<Integer> NASBackupBandwidthLimitMbps = new ConfigKey<>("Advanced", Integer.class,
138138
"nas.backup.bandwidth.limit.mbps",
139139
"0",
140-
"Bandwidth limit in MiB/s for backup operations (0 = unlimited).",
140+
"Bandwidth limit in MiB/s per disk for backup operations (0 = unlimited). The limit counts the virtual size of each disk, unallocated regions included, so a backup of a running VM takes about virtual size / limit regardless of how much of the disk is in use.",
141141
true,
142142
ConfigKey.Scope.Zone,
143143
BackupFrameworkEnabled.key());

0 commit comments

Comments
 (0)