Skip to content

Deny clippy::manual_assert_eq - #2644

Merged
LucaCappelletti94 merged 1 commit into
mainfrom
deny-manual-assert-eq
Oct 16, 2026
Merged

LucaCappelletti94 merged 1 commit into
mainfrom
deny-manual-assert-eq

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

As per title, this PR enables the manual_assert_eq clippy lint, and fixes the only one present at this time, preventing further future code smells.

@github-actions

Copy link
Copy Markdown

No dialect label was applied because the title does not name a SQL dialect.

If this change targets one or more dialects, edit the title to <Dialect>[, <Dialect>]: <description>, add a Dialects: <Dialect>[, <Dialect>] line to the description, or reply with one. Reply Dialects: none if the change is dialect-agnostic.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.20%. Comparing base (a80289f) to head (ca1782b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2644   +/-   ##
=======================================
  Coverage   81.20%   81.20%           
=======================================
  Files          42       42           
  Lines       33893    33893           
  Branches    33893    33893           
=======================================
  Hits        27523    27523           
  Misses       2796     2796           
  Partials     3574     3574           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alamb

alamb commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Something is wrong with the ClusterFuzz job 🤔

@LucaCappelletti94

Copy link
Copy Markdown
Contributor Author

Something is wrong with the ClusterFuzz job 🤔

Yeah I believe it is one of the errors for which I already opened a PR upstream but it has been ignored for a while, I guess we shall have to ignore it for the time being.

@LucaCappelletti94
LucaCappelletti94 added this pull request to the merge queue Oct 16, 2026
Merged via the queue into main with commit de73756 Oct 16, 2026
13 of 14 checks passed
@LucaCappelletti94

Copy link
Copy Markdown
Contributor Author

@alamb it is not a ClusterFuzzLite issue, it is a duckdb issue. They have already fixed it in main upstream, but still need to release the new version.

@alamb

alamb commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Strange that we need duckdb for this tool 🤷

@LucaCappelletti94

Copy link
Copy Markdown
Contributor Author

Strange that we need duckdb for this tool 🤷

duckdb is used in one of the differential harnesses to check that we do not reject statements that the duckdb parser accepts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants