[LucaCappelletti94]

CREATE TABLE t (a INT) ENGINE = "MergeTree" lost its quotes on display and was printed back as ENGINE = MergeTree, and the same happened to ENGINE = `InnoDB`, because the engine name was rebuilt with Ident::new from the bare word value.

Both engines accept a quoted engine name: ClickHouse quotes identifiers with double quotes or backticks (https://clickhouse.com/docs/reference/syntax#identifiers), and MySQL documents that the engine name can be unquoted or quoted (https://dev.mysql.com/doc/refman/8.4/en/create-table.html#create-table-options).

The engine name is now built with Word::into_ident, which keeps the original quote style and the token span.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.24%. Comparing base (7b5821d) to head (d64869e).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2655   +/-   ##
=======================================
  Coverage   81.24%   81.24%           
=======================================
  Files          42       42           
  Lines       33901    33901           
  Branches    33901    33901           
=======================================
  Hits        27543    27543           
  Misses       2792     2792           
  Partials     3566     3566           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[s5dsn-eqee]

lgtm!

[LucaCappelletti94]

Merging, thanks @s5dsn-eqee for the review!

cc @alamb

[alamb]

Thanks @LucaCappelletti94