Repository navigation
PostgreSQL: Parse OPTION FOR in a role membership REVOKE - #2736
Merged
LucaCappelletti94 merged 2 commits intoOct 28, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## upstream/postgres-revoke-role-membership #2736 +/- ##
===========================================================================
Coverage ? 82.41%
===========================================================================
Files ? 42
Lines ? 35402
Branches ? 35402
===========================================================================
Hits ? 29177
Misses ? 2679
Partials ? 3546 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LucaCappelletti94
force-pushed
the
upstream/postgres-revoke-role-option-for
branch
from
October 28, 2026 07:51
b2ccf09 to
e766f2c
Compare
sabir-akhadov-localstack
approved these changes
Oct 28, 2026
LucaCappelletti94
force-pushed
the
upstream/postgres-revoke-role-option-for
branch
from
October 28, 2026 11:29
e766f2c to
fffc66c
Compare
LucaCappelletti94
force-pushed
the
upstream/postgres-revoke-role-option-for
branch
from
October 28, 2026 11:56
fffc66c to
3ab6ea9
Compare
Contributor
Author
|
Thanks @sabir-akhadov-localstack for reviewing the stack of PRs, I will now merge both. cc @alamb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REVOKE ADMIN OPTION FOR bypasser FROM anonfailed withExpected: a privilege keyword, found: ADMIN. PostgreSQL withdraws one option of a role membership while keeping the membership withname OPTION FOR, such asADMIN OPTION FORor, from PostgreSQL 16,SET OPTION FOR(REVOKE).RevokeRolenow keeps the name asoption_for.GRANT OPTION FORstill goes to the privilege form, and the name stays an identifier because PostgreSQL's grammar accepts any name there.