Replies: 14 comments 12 replies
-
Beta Was this translation helpful? Give feedback.
-
|
Let me convert this to a Discussion post. sorry if that's not clear. for uncertain topics, we use disucussions. once a consensus is reached, we open an issue (or feel free to use umbrella issue + multiple sub-issues) to track decided todos. Discussions can have back and forth ideas. issues should be clear on what exactly to do. |
Beta Was this translation helpful? Give feedback.
-
|
@carloea2 Let's do a meeting to discuss the details and report the results here. |
Beta Was this translation helpful? Give feedback.
-
|
We discussed this feature offline. We agreed that the design in #5115 is more general in that it has explicit encapsulation of the input and output ports, and that the user chooses which ports of the macro workflow is exposed. |
Beta Was this translation helpful? Give feedback.
-
|
Maybe @carloea2 can take the lead to finish it? Notice that @Xiao-zhen-Liu's availability in the summer is limited. It will be good to have a discussion before that, and report the plan here. |
Beta Was this translation helpful? Give feedback.
-
|
I think we can wait for @Xiao-zhen-Liu to come back since he raised the PR first, and his design was chosen, I could take his code and raise the PRs but I feel it is not right |
Beta Was this translation helpful? Give feedback.
-
|
I don't think we're on the same page. Let's have a group discussion next Monday. If we cannot finish, we can have one more discussion on Wednesday. |
Beta Was this translation helpful? Give feedback.
-
|
We had an offline discussion about this topic. @carloea2 : please summarize the results. |
Beta Was this translation helpful? Give feedback.
-
|
In summary:
|
Beta Was this translation helpful? Give feedback.
-
|
@carloea2 Please provide more details as suggested. |
Beta Was this translation helpful? Give feedback.
-
|
@carloea2 Thanks for the summary. Not sure if I fully understand your question. I believe we are allowed to do offline discussions for efficiency reasons, but we need to publish the results and decisions here to maintain the transparency. |
Beta Was this translation helpful? Give feedback.
-
|
Hi, I was suggested to fold my recent proposal (#6066, now closed) into this discussion. I've been prototyping something adjacent to macros: a "Blocks" gallery for saving and reusing workflow pieces across workflows. Reading through this thread, my design is different in direction (drop-in reuse vs. in-place collapsing). But a few pieces from the prototype might be useful for the macros work:
Demo of the prototype: https://drive.google.com/file/d/12pPeBUvbLlsrO5t5pp0C9G2xeEordTD2/view?usp=sharing Would any of these be useful to fold into the macros direction? Thank you! |
Beta Was this translation helpful? Give feedback.
-
|
@carloea2 Please chime in. If needed, we can have a discussion and report the results here. |
Beta Was this translation helpful? Give feedback.
-
|
After meeting with @carloea2, here's a summary of what we discussed. The base macro feature (the #5115 direction — explicit input/output port encapsulation and in-place collapse) will be built first. Once it's merged, I can open separate PRs adding these extra features on top:
|
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Feature Summary
Workflow macros are an important feature for Texera, but the current discussion in #5179 mixes several design choices with implementation review. Based on the feedback from @Yicong-Huang and @chenlica, we should move the macro design discussion into an issue, hold a focused live discussion, and record the decisions here before continuing.
References:
Proposed Solution or Design
Use this issue to align on the macro design before reviewing code in detail. The discussion should decide:
Macro creation UX
Create Macrofrom the context menu?Macro representation and reuse
My Macros?Macro internal view and editing
Runtime and statistics behavior
Macro lifecycle and persistence
Impact / Priority
?
Affected Area
Beta Was this translation helpful? Give feedback.
All reactions