Add managed scalar callback foundation#4
Closed
awakecoding wants to merge 1 commit into
Closed
Conversation
Port the scalar-only callback foundation for managed external functions, including registration, invocation, result conversion, metadata, invalidation, and focused integration coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Owner
Author
|
Closing because this scalar split belongs upstream at tursodatabase/turso. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary- Port the managed scalar callback foundation from the all-in-one advanced APIs work.- Add scalar callback ABI/value types, registration/unregistration, scalar runtime invocation, result conversion, deterministic metadata, and prepared-statement invalidation.- Add focused scalar callback integration coverage for fixed and variadic callbacks, argument conversion, null/text/blob/error result conversion, callback error propagation, deterministic metadata, unregister/re-register invalidation, and context/value destructor counts.## ScopeThis PR is limited to managed scalar callback support. It intentionally does not include aggregate support, custom collations, extension-loading changes, SDK-kit changes, .NET exposure/facade/raw changes, workflow changes, or simulator changes.## Validation-
cargo fmt --check-git diff --check-cargo check -q -p core_tester --features pure-rust-crypto --test integration_tests-cargo clippy -q -p core_tester --features pure-rust-crypto --test integration_tests -- --deny=warnings-cargo test -q -p core_tester --features pure-rust-crypto --test integration_tests managed_scalar -- --nocaptureAn initial targeted test attempt failed during compilation withrustc-LLVM ERROR: IO failure on output stream: no space on device. That was environmental: build output was moved off the nearly-full C: drive, and all validation above passed afterward.