Skip to content

fix(tui): align radio dots and menu filter prefix colors - #2489

Merged
aidandaly24 merged 4 commits into
aws:refactorfrom
aidandaly24:fix/tui-selection-search-colors
Sep 30, 2026
Merged

aidandaly24 merged 4 commits into
aws:refactorfrom
aidandaly24:fix/tui-selection-search-colors

Conversation

@aidandaly24

@aidandaly24 aidandaly24 commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Description

Fixes the 09/30 RC bug-bash UX items 6 and 7:

  • Match the selected radio dot to its row's existing arrow/text color.
  • Color the static / beside "type to choose a command" using the existing focus accent.
  • Match the "use the command line..." sentence to its command example's accent color.

Only FormRadioGroup, RouterScreen, and one color value in HarnessWizard change. Footer hints and selected-label styling are unchanged. No new tests, helpers, theme changes, or keyboard behavior changes.

Screenshots of the actual TUI screens with synthetic example data:

Radio dot and command-line guidance use the same accent color

Static menu slash matches the interactive accent color

Related Issue

09/30 RC bug bash: UX items 6 and 7. No GitHub issue created.

Documentation PR

Not applicable: styling-only fix.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

Compared both updated screenshots with the reporter's original images and verified typing still filters the command menu. No color-specific tests added. AWS end-to-end tests are not applicable because no service behavior changed.

  • I ran bun test (3,949 pass, 0 fail)
  • I ran the relevant end-to-end tests with bun run test:e2e, or explained why they are not applicable
  • I ran bun run typecheck
  • I ran bun run lint:check
  • I ran bun run format:check
  • I ran bun run build
  • If I modified src/assets/, I updated affected snapshots with bun test <test-file> --update-snapshots and committed them

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@github-actions github-actions Bot added the size/xs PR size: XS label Sep 30, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Sep 30, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 30, 2026

@agentcore-devx-automation agentcore-devx-automation Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

Small, low-risk visual tweak that swaps theme.colors.selection for theme.colors.focus on the selected radio row and lights up the [/] filter hint. Verified against _core.ts — both colors exist and the intent (match the pointer arrow accent) is consistent with the rest of FormRadioGroup. No functional, security, or test concerns; telemetry is not applicable for a pure styling change.

Two optional cleanups the author may want to consider (non-blocking):

  • src/components/FormRadioGroup.tsx L66–70: the accentColor ternary now has two identical branches (focused ? focus : selected ? focus : undefined) and can be simplified to highlighted ? theme.colors.focus : undefined.
  • src/components/ui/key-hint/KeyHint.tsx L58: special-casing the literal "/" inside a generic reusable component is a bit of a smell. If more keys ever need the accent treatment, consider moving this to a per-item flag on KeyHintItem (e.g. accent?: boolean) rather than string-matching in the renderer. Fine to leave as-is for the RC fix.

Nothing here requires changes before merge.

@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Sep 30, 2026
@codecov-commenter

codecov-commenter commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.40%. Comparing base (04b45c3) to head (fec9497).
⚠️ Report is 4 commits behind head on refactor.

Additional details and impacted files
@@            Coverage Diff            @@
##           refactor    #2489   +/-   ##
=========================================
  Coverage     97.39%   97.40%           
=========================================
  Files           642      642           
  Lines         46807    46808    +1     
=========================================
+ Hits          45590    45591    +1     
  Misses         1217     1217           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aidandaly24 aidandaly24 changed the title fix(tui): align radio selection and filter hint colors fix(tui): align radio dots and menu filter prefix colors Sep 30, 2026
@github-actions github-actions Bot added size/xs PR size: XS and removed size/xs PR size: XS labels Sep 30, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Sep 30, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 30, 2026
@aidandaly24
aidandaly24 marked this pull request as ready for review September 30, 2026 22:03
notgitika
notgitika previously approved these changes Sep 30, 2026
@aidandaly24
aidandaly24 merged commit 24af90f into aws:refactor Sep 30, 2026
13 of 14 checks passed
@github-actions github-actions Bot added size/xs PR size: XS and removed size/xs PR size: XS labels Sep 30, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Sep 30, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants