fix(tui): align radio dots and menu filter prefix colors - #2489
Conversation
|
Claude Security Review: no high-confidence findings. (run) |
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Small, low-risk visual tweak that swaps theme.colors.selection for theme.colors.focus on the selected radio row and lights up the [/] filter hint. Verified against _core.ts — both colors exist and the intent (match the pointer arrow accent) is consistent with the rest of FormRadioGroup. No functional, security, or test concerns; telemetry is not applicable for a pure styling change.
Two optional cleanups the author may want to consider (non-blocking):
src/components/FormRadioGroup.tsxL66–70: theaccentColorternary now has two identical branches (focused ? focus : selected ? focus : undefined) and can be simplified tohighlighted ? theme.colors.focus : undefined.src/components/ui/key-hint/KeyHint.tsxL58: special-casing the literal"/"inside a generic reusable component is a bit of a smell. If more keys ever need the accent treatment, consider moving this to a per-item flag onKeyHintItem(e.g.accent?: boolean) rather than string-matching in the renderer. Fine to leave as-is for the RC fix.
Nothing here requires changes before merge.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2489 +/- ##
=========================================
Coverage 97.39% 97.40%
=========================================
Files 642 642
Lines 46807 46808 +1
=========================================
+ Hits 45590 45591 +1
Misses 1217 1217 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Claude Security Review: no high-confidence findings. (run) |
|
Claude Security Review: no high-confidence findings. (run) |
Description
Fixes the 09/30 RC bug-bash UX items 6 and 7:
/beside "type to choose a command" using the existing focus accent.Only
FormRadioGroup,RouterScreen, and one color value inHarnessWizardchange. Footer hints and selected-label styling are unchanged. No new tests, helpers, theme changes, or keyboard behavior changes.Screenshots of the actual TUI screens with synthetic example data:
Related Issue
09/30 RC bug bash: UX items 6 and 7. No GitHub issue created.
Documentation PR
Not applicable: styling-only fix.
Type of Change
Testing
Compared both updated screenshots with the reporter's original images and verified typing still filters the command menu. No color-specific tests added. AWS end-to-end tests are not applicable because no service behavior changed.
bun test(3,949 pass, 0 fail)bun run test:e2e, or explained why they are not applicablebun run typecheckbun run lint:checkbun run format:checkbun run buildsrc/assets/, I updated affected snapshots withbun test <test-file> --update-snapshotsand committed themChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.