From 317c4c6579e37bc5d09719b7e05af69758e411f6 Mon Sep 17 00:00:00 2001 From: Martin Laws Date: Thu, 30 Jul 2026 01:24:28 -0400 Subject: [PATCH] Fix `make tools` installing golangci-lint v1 against a v2 config MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `make tools` installed from the v1 module path while .golangci.yml is version: "2", so `make lint` fails immediately after a clean setup: Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2 make: *** [lint] Error 3 CI does not catch this because it never runs `make tools` — ci.yml and test.yml both use golangci-lint-action pinned to v2.10.1. The break only surfaces for someone setting up locally from CONTRIBUTING.md. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index a674712c..37394f9e 100644 --- a/Makefile +++ b/Makefile @@ -247,7 +247,7 @@ clean-pgo: # Install dev tools tools: - go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest + go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest go install golang.org/x/vuln/cmd/govulncheck@latest @echo "For gitleaks, install via: brew install gitleaks (or see https://github.com/gitleaks/gitleaks)" @echo "For benchstat: go install golang.org/x/perf/cmd/benchstat@latest"