Allow koriym/semantic-logger 0.9 - #78
Conversation
`^0.8` reads as `<0.9`, so an application cannot install this framework beside a package that requires 0.9 — BEAR.QueryRepository 1.x now does, and the two conflict at resolution time. Nothing here needs the old contract. This framework only calls `open()` and `close()`, whose signatures are identical in both versions, and references three symbols that all exist in 0.9 (`AbstractContext`, `SemanticLogger`, `SemanticLoggerInterface`). The exception hierarchy 0.9 removed was never caught, and `flush()` is never called from here. 0.9 freezes a recorded context, so a map arrives from `toArray()` as an object where 0.8 handed back an array. Only the log-shape test looked; the cast it now does reads the same under both versions. Verified: 252 tests green on 0.9.0 and again on 0.8.0.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe dependency constraint now permits ChangesSemantic logger compatibility
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to The PR broadens semantic-logger compatibility to 0.9 while preserving 0.8 behavior and updates the affected test expectation; both supported versions pass the test suite, so no actionable merge-blocking risk remains after normal checks. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 PHPStan (2.2.7)PHP Parse error: syntax error, unexpected token "->", expecting ";" in /vendor/php-standard-library/php-standard-library/packages/class/src/Psl/Class/has_constant.php on line 16 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bootstrap が使う UriScopedHttpCacheInterface は 1.16.2 に未収録。 1.x-dev は koriym/semantic-logger ^0.9 を要求するため、be-framework/be は それを許す dev-semantic-logger-0.9 (be-framework/Be.Framework#78) に合わせる。
1 participant
^0.8reads as<0.9, so an application cannot install this framework beside a package that requires semantic-logger 0.9. BEAR.QueryRepository1.xnow does, and the two conflict at resolution time — found while installing it into BeMart.Nothing here needs the old contract:
open()andclose(), whose signatures are identical in 0.8 and 0.9AbstractContext,SemanticLogger,SemanticLoggerInterfaceflush()is never called from this packageOne test needed a change. 0.9 freezes a recorded context, so a map comes back from
toArray()as an object where 0.8 handed back an array.LoggerTest::testOpenChainLogsInputPropswas the only place that looked; the cast it now does reads the same under both versions.Verified: 252 tests green on 0.9.0, then again after pinning 0.8.0 — both branches of the constraint hold.
Summary by CodeRabbit
Bug Fixes
Chores