Skip to content

Fix broken links to Metamorphosis chapter in Being Classes pages - #22

Merged
koriym merged 1 commit into
be-framework:masterfrom
takigawaakinori:master
Apr 16, 2026
Merged

koriym merged 1 commit into
be-framework:masterfrom
takigawaakinori:master

Conversation

@takigawaakinori

@takigawaakinori takigawaakinori commented Apr 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • 03-being-classes.md(日英)の変容章へのリンクを修正
  • ./05-metamorphosis-patterns.html → ./05-metamorphosis.html

05-metamorphosis-patterns.md の permalink は 05-metamorphosis.html であり、ファイル名ベースの 05-metamorphosis-patterns.html は存在しない。

Test plan

  • Jekyll buildが通ること
  • 日英の Being Classes ページから Metamorphosis 章へのリンクが正しく遷移すること

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Corrected chapter reference links in the "Being Classes" section of the manual documentation for both English and Japanese versions. Updated cross-references to point to the correct chapter file, improving documentation navigation and consistency across all supported languages. These changes ensure users can reliably access related chapter materials without encountering broken or incorrect links.

The permalink for 05-metamorphosis-patterns.md is 05-metamorphosis.html,
not 05-metamorphosis-patterns.html.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Apr 1, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 68323799-f071-4661-8d83-cc5e6fd199ae

📥 Commits

Reviewing files that changed from the base of the PR and between ac150aa and 0eb01bb.

📒 Files selected for processing (2)
  • manuals/1.0/en/03-being-classes.md
  • manuals/1.0/ja/03-being-classes.md

📝 Walkthrough

Walkthrough

This PR updates internal documentation hyperlinks across two language versions of a manual. Both the English and Japanese "Being Classes" documentation files have their Chapter 5 reference links corrected from ./05-metamorphosis-patterns.html to ./05-metamorphosis.html.

Changes

Cohort / File(s) Summary
Documentation Link Updates
manuals/1.0/en/03-being-classes.md, manuals/1.0/ja/03-being-classes.md
Updated internal document links to Chapter 5 from ./05-metamorphosis-patterns.html to ./05-metamorphosis.html in both English and Japanese manual versions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A rabbit hops through links so fine,
Fixing paths in each language line,
From patterns old to metamorphosis new,
Two docs corrected—the old link flew! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: fixing broken documentation links to the Metamorphosis chapter in the Being Classes pages.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@takigawaakinori
takigawaakinori marked this pull request as ready for review April 1, 2026 23:45
@claude

claude Bot commented Apr 16, 2026

Copy link
Copy Markdown

Code Review

PR #22: Fix broken links to Metamorphosis chapter in Being Classes pages

Overview

Minimal, targeted bug fix: corrects two cross-reference links that pointed to 05-metamorphosis-patterns.html (the filename-derived URL) instead of 05-metamorphosis.html (the actual permalink in the frontmatter of 05-metamorphosis-patterns.md).

Verdict: Correct and ready to merge

Code Quality

  • Fix is accurate. 05-metamorphosis-patterns.md declares permalink: /manuals/1.0/en/05-metamorphosis.html, so the old link would have 404'd.
  • Both EN and JA versions are updated symmetrically — consistent with project conventions requiring mirrored permalink paths across languages.
  • Follows the CLAUDE.md guideline of using .html extensions for cross-links.

No concerns — straightforward correctness fix with no behavioral changes, performance implications, or security considerations.

Minor suggestion: The test plan checklist is a good addition. Worth also verifying by running ./bin/serve.sh locally and clicking through from both language versions of the Being Classes page to confirm the link resolves correctly.

@koriym
koriym merged commit 9093d99 into be-framework:master Apr 16, 2026
1 of 2 checks passed
@koriym

koriym commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

@takigawaakinori ARIGATO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants