Add code-style job to CI pipeline with spotless and jdeps checks#92
Merged
Conversation
…print Root cause of the prior publish-snapshot failure: spotless:check is bound to the verify phase, which ONLY the publish 'deploy' goal reaches — every compile/test/ package job stops before verify, so unformatted code passed all of them and only failed at the final publish step. Fix: a new 'code-style' job (needs: startgate) runs 'mvn spotless:check' early (fail-fast) and is now a dependency of publish-snapshot / publish-release, so publish cannot run on unformatted code. The same job also prints the internal package dependency graph via jdeps (informational, continue-on-error) — the bytecode-level layering itself is already enforced by the ArchUnit layeredArchitecture()/noPackageCycles rules in 'mvn test'. https://claude.ai/code/session_018JD9GHTJ3GNaT57iqfK3nP
bernardladenthin
temporarily deployed
to
startgate
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
=========================================
Coverage 96.88% 96.88%
Complexity 94 94
=========================================
Files 1 1
Lines 257 257
Branches 33 33
=========================================
Hits 249 249
Misses 2 2
Partials 6 6 ☔ View full report in Codecov by Harness. |
|
coverage: 99.222%. remained the same — claude/affectionate-darwin-469lR into main |
Matches Dependabot's java-llama.cpp #215 (and the equivalent per-repo bump); applied on the shared feature branch so it rides the existing PR for this repo instead of a separate Dependabot merge to main.
bernardladenthin
temporarily deployed
to
startgate
GitHub Actions
Inactive
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
code-styleCI job that runs Spotless code formatting checks and prints the internal package dependency graph via jdepscode-stylejob a required dependency for both snapshot and release publishing workflowsTest plan
Related issues / PRs
Checklist
CONTRIBUTING.mdandCODE_OF_CONDUCT.mdSECURITY.md)https://claude.ai/code/session_018JD9GHTJ3GNaT57iqfK3nP