Context
PR #278 (merged into v0.1.x) introduced the initial unit test setup for the data-consumption engine (vitest + testing-library under tests/unit/), and noted as a follow-up that these tests should be wired into the automated CI workflow once we decide to keep them going forward.
PR #279 is the backport of #278 into v0.0.x. It carries the same test suite and the same fix, but the "More" section of the original PR body (which tracked that follow-up) was dropped during backport, so the line v0.0.x currently has no tracking of this gap.
Problem
On v0.0.x, npm run test:unit (vitest) is not invoked by any CI workflow:
.github/workflows/ts-code-compilation.yml runs npx tsc against the root tsconfig.json (include: ["src/**/*.ts"]), which does not type-check tests/.
.github/workflows/ts-code-validation.yml runs npm run lint, which does cover tests/, but does not execute the tests.
- No workflow calls
test:unit.
As a result, the unit suite introduced by #279 runs only locally and acts as executable documentation, not as a regression gate.
Proposal
Add test:unit to the automated CI on v0.0.x, mirroring whatever pattern the v0.1.x line adopts (or, if v0.1.x has not done it yet, establishing the pattern here). A reference implementation exists in the bbb-plugin-pick-random-user plugin CI.
Related
Context
PR #278 (merged into
v0.1.x) introduced the initial unit test setup for the data-consumption engine (vitest + testing-library undertests/unit/), and noted as a follow-up that these tests should be wired into the automated CI workflow once we decide to keep them going forward.PR #279 is the backport of #278 into
v0.0.x. It carries the same test suite and the same fix, but the "More" section of the original PR body (which tracked that follow-up) was dropped during backport, so the linev0.0.xcurrently has no tracking of this gap.Problem
On
v0.0.x,npm run test:unit(vitest) is not invoked by any CI workflow:.github/workflows/ts-code-compilation.ymlrunsnpx tscagainst the roottsconfig.json(include: ["src/**/*.ts"]), which does not type-checktests/..github/workflows/ts-code-validation.ymlrunsnpm run lint, which does covertests/, but does not execute the tests.test:unit.As a result, the unit suite introduced by #279 runs only locally and acts as executable documentation, not as a regression gate.
Proposal
Add
test:unitto the automated CI onv0.0.x, mirroring whatever pattern thev0.1.xline adopts (or, ifv0.1.xhas not done it yet, establishing the pattern here). A reference implementation exists in thebbb-plugin-pick-random-userplugin CI.Related
v0.1.x): fix(data-consumption): unsubscribe with current args on unmount & test: initial unit test setup #278