From b91a03914de0bb05ed762839e1d0befdbbdc6b14 Mon Sep 17 00:00:00 2001 From: Gabriel Masclef Date: Fri, 21 Aug 2026 12:15:00 -0300 Subject: [PATCH] Chore: remove unnecessary simplexGetEvents endpoint --- .../src/externalservices/simplex.ts | 30 ------------------- .../src/lib/routes/services.ts | 15 +--------- .../externalservices/simplex.test.ts | 18 ----------- 3 files changed, 1 insertion(+), 62 deletions(-) diff --git a/packages/bitcore-wallet-service/src/externalservices/simplex.ts b/packages/bitcore-wallet-service/src/externalservices/simplex.ts index a207577e030..fab23f2bff4 100644 --- a/packages/bitcore-wallet-service/src/externalservices/simplex.ts +++ b/packages/bitcore-wallet-service/src/externalservices/simplex.ts @@ -248,34 +248,4 @@ export class SimplexService { ); }); } - - simplexGetEvents(req): Promise { - return new Promise((resolve, reject) => { - if (!config.simplex) return reject(new Error('Simplex missing credentials')); - if (!req.env || (req.env != 'sandbox' && req.env != 'production')) - return reject(new Error("Simplex's request wrong environment")); - - const API = config.simplex[req.env].api; - const API_KEY = config.simplex[req.env].apiKey; - const headers = { - 'Content-Type': 'application/json', - Authorization: 'ApiKey ' + API_KEY - }; - - this.request.get( - API + '/wallet/merchant/v2/events', - { - headers, - json: true - }, - (err, data) => { - if (err) { - return reject(err.body ? err.body : null); - } else { - return resolve(data.body ? data.body : null); - } - } - ); - }); - } } \ No newline at end of file diff --git a/packages/bitcore-wallet-service/src/lib/routes/services.ts b/packages/bitcore-wallet-service/src/lib/routes/services.ts index 349188bb30a..178b7df1d16 100644 --- a/packages/bitcore-wallet-service/src/lib/routes/services.ts +++ b/packages/bitcore-wallet-service/src/lib/routes/services.ts @@ -65,7 +65,7 @@ function respondWithAuthServer(req, res, context: RouteContext, handler: RouteHa } export function registerServiceRoutes(router: express.Router, context: RouteContext) { - const { getServerWithAuth, setPublicCache, returnError } = context; + const { setPublicCache } = context; const transakCorsOptions = { origin: (origin, cb) => { @@ -399,19 +399,6 @@ export function registerServiceRoutes(router: express.Router, context: RouteCont }); }); - router.get('/v1/service/simplex/events', (req, res) => { - getServerWithAuth(req, res, server => { - Promise.resolve() - .then(() => server.externalServices.simplex.simplexGetEvents({ env: req.query.env })) - .then(response => { - res.json(response); - }) - .catch(err => { - returnError(err ?? 'unknown', res, req); - }); - }); - }); - router.post('/v1/service/thorswap/supportedChains', (req, res) => { respondWithPublicServer(req, res, context, server => { return server.externalServices.thorswap.thorswapGetSupportedChains(req); diff --git a/packages/bitcore-wallet-service/test/integration/externalservices/simplex.test.ts b/packages/bitcore-wallet-service/test/integration/externalservices/simplex.test.ts index bc6972c8480..bfae0934106 100644 --- a/packages/bitcore-wallet-service/test/integration/externalservices/simplex.test.ts +++ b/packages/bitcore-wallet-service/test/integration/externalservices/simplex.test.ts @@ -363,22 +363,4 @@ describe('Simplex integration', () => { } }); }); - - describe('#simplexGetEvents', () => { - beforeEach(() => { - req = { - env: 'production' - }; - - fakeRequest = { - get: (_url, _opts, _cb) => { return _cb(null, { body: {} }); }, - }; - server.externalServices.simplex.request = fakeRequest; - }); - - it('should work properly if req is OK', async () => { - const data = await server.externalServices.simplex.simplexGetEvents(req); - should.exist(data); - }); - }); }); \ No newline at end of file