When generating a list of which parts of IOOPM every student is done with, the calculation for being done with the project is still based on how the course was stuctured in 2021:
|
if (achievementsSize >= 4 && projectAchievementsSize == 6) { |
|
credits.add(AcademicCreditType.PROJECT); |
|
achievementsSize -= 4; |
|
} |
(the feature was not used for the course instance of 2022, which is why the bug was not discovered until now)
The correct calculation should just check that all seven project goals are completed (should probably check that they are all done, rather than using the magic number seven) and to not subtract any achievements if the project is completed. See Section 10 here for the definitions of being done.
When generating a list of which parts of IOOPM every student is done with, the calculation for being done with the project is still based on how the course was stuctured in 2021:
bubify-backend/src/main/java/com/uu/au/models/User.java
Lines 250 to 253 in d9edd6f
(the feature was not used for the course instance of 2022, which is why the bug was not discovered until now)
The correct calculation should just check that all seven project goals are completed (should probably check that they are all done, rather than using the magic number seven) and to not subtract any achievements if the project is completed. See Section 10 here for the definitions of being done.