-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathadmin.go
More file actions
504 lines (470 loc) · 15.2 KB
/
admin.go
File metadata and controls
504 lines (470 loc) · 15.2 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
package main
import (
"context"
"crypto/sha1"
"encoding/hex"
"encoding/json"
"errors"
"fmt"
"io"
"net/url"
"regexp"
"strings"
"cloud.google.com/go/iam"
"github.com/aws/aws-sdk-go-v2/aws"
"github.com/aws/aws-sdk-go-v2/service/s3"
s3types "github.com/aws/aws-sdk-go-v2/service/s3/types"
"github.com/aws/smithy-go"
)
const (
storageAdmin iam.RoleName = "roles/storage.admin"
storageObjectAdmin iam.RoleName = "roles/storage.objectAdmin"
storageObjectViewer iam.RoleName = "roles/storage.objectViewer"
storageLegacyBucketReader iam.RoleName = "roles/storage.legacyBucketReader"
)
type adminGrantOptions struct {
provider string
bucket string
prefix string
action string
member string
serviceAccount bool
}
func adminCommand(cfg config, args []string, stdout io.Writer) error {
opts, err := parseAdminGrantArgs(args)
if err != nil {
return err
}
if opts.bucket != "" {
cfg.bucket = opts.bucket
}
if opts.prefix != "" {
cfg.prefix = opts.prefix
}
if opts.provider != "" {
cfg.provider = opts.provider
}
cfg.bucket = normalizeAdminBucket(cfg.bucket)
if cfg.bucket == "" {
localCfg, err := readLocalConfig(".")
if err == nil {
cfg = mergeConfig(cfg, localCfg)
}
}
if cfg.bucket == "" {
return errors.New("admin requires a bucket; run inside a bgit checkout or pass --bucket BUCKET")
}
ctx := context.Background()
if cfg.provider == "s3" {
return adminS3Command(ctx, cfg, opts, stdout)
}
if isAdminVisibilityAction(opts.action) {
return adminGCSVisibilityCommand(ctx, cfg, opts, stdout)
}
roles, label, err := adminGrantRoles(opts.action)
if err != nil {
return err
}
member := normalizeIAMMember(opts.member, opts.serviceAccount)
client, err := newStorageClient(ctx, cfg)
if err != nil {
return fmt.Errorf("create storage client: %w", err)
}
defer client.Close()
handle := client.Bucket(cfg.bucket).IAM()
policy, err := handle.Policy(ctx)
if err != nil {
return fmt.Errorf("get IAM policy for gs://%s: %w", cfg.bucket, err)
}
for _, role := range roles {
policy.Add(member, role)
}
if err := handle.SetPolicy(ctx, policy); err != nil {
return fmt.Errorf("set IAM policy for gs://%s: %w", cfg.bucket, err)
}
fmt.Fprintf(stdout, "granted %s access to %s on gs://%s\n", label, member, cfg.bucket)
return nil
}
func parseAdminGrantArgs(args []string) (adminGrantOptions, error) {
var opts adminGrantOptions
var positional []string
for i := 0; i < len(args); i++ {
arg := args[i]
switch {
case arg == "--bucket":
i++
if i >= len(args) || args[i] == "" {
return opts, errors.New("admin --bucket requires a bucket name")
}
opts.provider, opts.bucket, opts.prefix = normalizeAdminTarget(args[i])
case strings.HasPrefix(arg, "--bucket="):
opts.provider, opts.bucket, opts.prefix = normalizeAdminTarget(strings.TrimPrefix(arg, "--bucket="))
if opts.bucket == "" {
return opts, errors.New("admin --bucket requires a bucket name")
}
case arg == "--service-account":
opts.serviceAccount = true
default:
positional = append(positional, arg)
}
}
if len(positional) == 0 {
return opts, errors.New("usage: bgit admin grant-read|grant-write|grant-admin IDENTITY")
}
opts.action = normalizeAdminAction(positional[0])
if isAdminVisibilityAction(opts.action) {
if len(positional) != 1 {
return opts, errors.New("usage: bgit admin make-public|make-private")
}
return opts, nil
}
if len(positional) != 2 {
return opts, errors.New("usage: bgit admin grant-read|grant-write|grant-admin IDENTITY")
}
if _, _, err := adminGrantRoles(opts.action); err != nil {
return opts, err
}
opts.member = positional[1]
if opts.member == "" {
return opts, errors.New("admin grant requires an identity")
}
return opts, nil
}
func isAdminVisibilityAction(action string) bool {
switch normalizeAdminAction(action) {
case "make-public", "public", "make-private", "private":
return true
default:
return false
}
}
func normalizeAdminBucket(raw string) string {
_, bucket, _ := normalizeAdminTarget(raw)
return bucket
}
func normalizeAdminTarget(raw string) (string, string, string) {
bucket := strings.TrimSpace(raw)
if bucket == "" {
return "", "", ""
}
if strings.HasPrefix(bucket, "gs://") || strings.HasPrefix(bucket, "gcs://") || strings.HasPrefix(bucket, "s3://") {
parsed, err := url.Parse(bucket)
if err == nil && parsed.Host != "" {
provider := "gcs"
if parsed.Scheme == "s3" {
provider = "s3"
}
return provider, parsed.Host, strings.Trim(parsed.Path, "/")
}
}
bucket = strings.Trim(bucket, "/")
if slash := strings.Index(bucket, "/"); slash >= 0 {
return "", bucket[:slash], strings.Trim(bucket[slash+1:], "/")
}
return "", bucket, ""
}
func normalizeAdminAction(action string) string {
action = strings.ToLower(strings.TrimSpace(action))
action = strings.ReplaceAll(action, "_", "-")
action = strings.TrimPrefix(action, "grant-")
action = strings.TrimSuffix(action, "-access")
return action
}
func adminGrantRoles(action string) ([]iam.RoleName, string, error) {
switch normalizeAdminAction(action) {
case "read":
return []iam.RoleName{storageObjectViewer, storageLegacyBucketReader}, "read", nil
case "write":
return []iam.RoleName{storageObjectAdmin, storageLegacyBucketReader}, "write", nil
case "admin":
return []iam.RoleName{storageAdmin}, "admin", nil
default:
return nil, "", errors.New("supported admin commands: grant-read, grant-write, grant-admin, make-public, make-private")
}
}
func adminGCSVisibilityCommand(ctx context.Context, cfg config, opts adminGrantOptions, stdout io.Writer) error {
client, err := newStorageClient(ctx, cfg)
if err != nil {
return fmt.Errorf("create storage client: %w", err)
}
defer client.Close()
handle := client.Bucket(cfg.bucket).IAM()
policy, err := handle.Policy(ctx)
if err != nil {
return fmt.Errorf("get IAM policy for gs://%s: %w", cfg.bucket, err)
}
switch normalizeAdminAction(opts.action) {
case "make-public", "public":
policy.Add("allUsers", storageObjectViewer)
policy.Add("allUsers", storageLegacyBucketReader)
if err := handle.SetPolicy(ctx, policy); err != nil {
return fmt.Errorf("set IAM policy for gs://%s: %w", cfg.bucket, err)
}
fmt.Fprintf(stdout, "made gs://%s public\n", cfg.bucket)
case "make-private", "private":
for _, member := range []string{"allUsers", "allAuthenticatedUsers"} {
policy.Remove(member, storageObjectViewer)
policy.Remove(member, storageLegacyBucketReader)
}
if err := handle.SetPolicy(ctx, policy); err != nil {
return fmt.Errorf("set IAM policy for gs://%s: %w", cfg.bucket, err)
}
fmt.Fprintf(stdout, "made gs://%s private\n", cfg.bucket)
default:
return errors.New("supported visibility commands: make-public, make-private")
}
return nil
}
func normalizeIAMMember(raw string, serviceAccount bool) string {
member := strings.TrimSpace(raw)
if member == "allUsers" || member == "allAuthenticatedUsers" || strings.Contains(member, ":") {
return member
}
if serviceAccount || strings.HasSuffix(member, ".gserviceaccount.com") {
return "serviceAccount:" + member
}
return "user:" + member
}
type s3BucketPolicy struct {
Version string `json:"Version"`
Statement []s3PolicyStatement `json:"Statement"`
}
type s3PolicyStatement struct {
Sid string `json:"Sid,omitempty"`
Effect string `json:"Effect"`
Principal any `json:"Principal"`
Action any `json:"Action"`
Resource any `json:"Resource"`
Condition map[string]map[string]any `json:"Condition,omitempty"`
}
func adminS3Command(ctx context.Context, cfg config, opts adminGrantOptions, stdout io.Writer) error {
client, err := newS3Client(ctx, cfg, false)
if err != nil {
return fmt.Errorf("create S3 client: %w", err)
}
if isAdminVisibilityAction(opts.action) {
return adminS3VisibilityCommand(ctx, client, cfg, opts, stdout)
}
principal, err := normalizeAWSPrincipal(opts.member)
if err != nil {
return err
}
policy, err := readS3BucketPolicy(ctx, client, cfg.bucket)
if err != nil {
return err
}
label := normalizeAdminAction(opts.action)
policy.addBucketGitGrant(cfg.bucket, cfg.prefix, label, principal)
if err := writeS3BucketPolicy(ctx, client, cfg.bucket, policy); err != nil {
return err
}
target := s3AdminTarget(cfg)
fmt.Fprintf(stdout, "granted %s access to %s on %s\n", label, principal, target)
return nil
}
func adminS3VisibilityCommand(ctx context.Context, client *s3.Client, cfg config, opts adminGrantOptions, stdout io.Writer) error {
target := s3AdminTarget(cfg)
policy, err := readS3BucketPolicy(ctx, client, cfg.bucket)
if err != nil {
return err
}
switch normalizeAdminAction(opts.action) {
case "make-public", "public":
if _, err := client.DeletePublicAccessBlock(ctx, &s3.DeletePublicAccessBlockInput{
Bucket: aws.String(cfg.bucket),
}); err != nil && !isS3NoSuchPublicAccessBlock(err) {
return fmt.Errorf("delete public access block for s3://%s: %w", cfg.bucket, err)
}
policy.addBucketGitGrant(cfg.bucket, cfg.prefix, "read", "*")
if err := writeS3BucketPolicy(ctx, client, cfg.bucket, policy); err != nil {
return err
}
fmt.Fprintf(stdout, "made %s public\n", target)
case "make-private", "private":
policy.removeBucketGitPublicGrants(cfg.prefix)
if err := writeS3BucketPolicy(ctx, client, cfg.bucket, policy); err != nil {
return err
}
if _, err := client.PutPublicAccessBlock(ctx, &s3.PutPublicAccessBlockInput{
Bucket: aws.String(cfg.bucket),
PublicAccessBlockConfiguration: &s3types.PublicAccessBlockConfiguration{
BlockPublicAcls: aws.Bool(true),
IgnorePublicAcls: aws.Bool(true),
BlockPublicPolicy: aws.Bool(true),
RestrictPublicBuckets: aws.Bool(true),
},
}); err != nil {
return fmt.Errorf("set public access block for s3://%s: %w", cfg.bucket, err)
}
fmt.Fprintf(stdout, "made %s private\n", target)
default:
return errors.New("supported visibility commands: make-public, make-private")
}
return nil
}
func writeS3BucketPolicy(ctx context.Context, client *s3.Client, bucket string, policy s3BucketPolicy) error {
if len(policy.Statement) == 0 {
if _, err := client.DeleteBucketPolicy(ctx, &s3.DeleteBucketPolicyInput{Bucket: aws.String(bucket)}); err != nil && !isS3NoSuchBucketPolicy(err) {
return fmt.Errorf("delete bucket policy for s3://%s: %w", bucket, err)
}
return nil
}
data, err := json.Marshal(policy)
if err != nil {
return err
}
if _, err := client.PutBucketPolicy(ctx, &s3.PutBucketPolicyInput{
Bucket: aws.String(bucket),
Policy: aws.String(string(data)),
}); err != nil {
return fmt.Errorf("set bucket policy for s3://%s: %w", bucket, err)
}
return nil
}
func s3AdminTarget(cfg config) string {
target := fmt.Sprintf("s3://%s", cfg.bucket)
if strings.Trim(cfg.prefix, "/") != "" {
target += "/" + strings.Trim(cfg.prefix, "/")
}
return target
}
func readS3BucketPolicy(ctx context.Context, client *s3.Client, bucket string) (s3BucketPolicy, error) {
out, err := client.GetBucketPolicy(ctx, &s3.GetBucketPolicyInput{Bucket: aws.String(bucket)})
if err != nil {
if isS3NoSuchBucketPolicy(err) {
return s3BucketPolicy{Version: "2012-10-17"}, nil
}
return s3BucketPolicy{}, fmt.Errorf("get bucket policy for s3://%s: %w", bucket, err)
}
policy := s3BucketPolicy{}
if err := json.Unmarshal([]byte(aws.ToString(out.Policy)), &policy); err != nil {
return s3BucketPolicy{}, fmt.Errorf("parse bucket policy for s3://%s: %w", bucket, err)
}
if policy.Version == "" {
policy.Version = "2012-10-17"
}
return policy, nil
}
func (p *s3BucketPolicy) addBucketGitGrant(bucket, prefix, action, principal string) {
if p.Version == "" {
p.Version = "2012-10-17"
}
prefix = strings.Trim(prefix, "/")
baseSid := s3GrantSid(action, principal, prefix)
p.removeStatements(baseSid)
for _, statement := range s3GrantStatements(bucket, prefix, action, principal, baseSid) {
p.Statement = append(p.Statement, statement)
}
}
func (p *s3BucketPolicy) removeStatements(baseSid string) {
var statements []s3PolicyStatement
for _, statement := range p.Statement {
if statement.Sid != baseSid+"List" && statement.Sid != baseSid+"Objects" && statement.Sid != baseSid+"Admin" {
statements = append(statements, statement)
}
}
p.Statement = statements
}
func (p *s3BucketPolicy) removeBucketGitPublicGrants(prefix string) {
prefix = strings.Trim(prefix, "/")
for _, action := range []string{"read", "write", "admin"} {
p.removeStatements(s3GrantSid(action, "*", prefix))
}
}
func s3GrantStatements(bucket, prefix, action, principal, baseSid string) []s3PolicyStatement {
bucketARN := "arn:aws:s3:::" + bucket
objectARN := bucketARN + "/*"
if prefix != "" {
objectARN = bucketARN + "/" + prefix + "/*"
}
principalValue := any(map[string]any{"AWS": principal})
if principal == "*" {
principalValue = "*"
}
switch action {
case "admin":
return []s3PolicyStatement{{
Sid: baseSid + "Admin",
Effect: "Allow",
Principal: principalValue,
Action: "s3:*",
Resource: []string{bucketARN, objectARN},
}}
case "write":
return []s3PolicyStatement{
s3ListStatement(bucketARN, prefix, principalValue, baseSid),
{
Sid: baseSid + "Objects",
Effect: "Allow",
Principal: principalValue,
Action: []string{"s3:GetObject", "s3:PutObject", "s3:DeleteObject", "s3:AbortMultipartUpload"},
Resource: objectARN,
},
}
default:
return []s3PolicyStatement{
s3ListStatement(bucketARN, prefix, principalValue, baseSid),
{
Sid: baseSid + "Objects",
Effect: "Allow",
Principal: principalValue,
Action: "s3:GetObject",
Resource: objectARN,
},
}
}
}
func s3ListStatement(bucketARN, prefix string, principal any, baseSid string) s3PolicyStatement {
statement := s3PolicyStatement{
Sid: baseSid + "List",
Effect: "Allow",
Principal: principal,
Action: "s3:ListBucket",
Resource: bucketARN,
}
if prefix != "" {
statement.Condition = map[string]map[string]any{
"StringLike": {
"s3:prefix": []string{prefix, prefix + "/*"},
},
}
}
return statement
}
func s3GrantSid(action, principal, prefix string) string {
sum := sha1.Sum([]byte(action + "\x00" + principal + "\x00" + prefix))
return "BucketGit" + strings.Title(action) + hex.EncodeToString(sum[:])[:12]
}
func normalizeAWSPrincipal(raw string) (string, error) {
principal := strings.TrimSpace(raw)
if principal == "" {
return "", errors.New("AWS principal is required")
}
if principal == "*" || principal == "allUsers" {
return "*", nil
}
if strings.HasPrefix(principal, "arn:aws:iam::") || strings.HasPrefix(principal, "arn:aws:sts::") {
return principal, nil
}
if regexp.MustCompile(`^\d{12}$`).MatchString(principal) {
return "arn:aws:iam::" + principal + ":root", nil
}
return "", errors.New("AWS admin identity must be an IAM/STS ARN, a 12 digit AWS account ID, or *")
}
func isS3NoSuchBucketPolicy(err error) bool {
var apiErr smithy.APIError
if errors.As(err, &apiErr) {
return apiErr.ErrorCode() == "NoSuchBucketPolicy"
}
return false
}
func isS3NoSuchPublicAccessBlock(err error) bool {
var apiErr smithy.APIError
if errors.As(err, &apiErr) {
switch apiErr.ErrorCode() {
case "NoSuchPublicAccessBlockConfiguration", "NoSuchPublicAccessBlock", "NoSuchBucket", "NotFound", "404":
return true
}
}
return false
}