From 23f0d2f1f997143f07d5903a101cae871dcc8221 Mon Sep 17 00:00:00 2001 From: ADmad Date: Sun, 5 Jul 2026 23:27:04 +0530 Subject: [PATCH] Replace our TabAndSpaceSniff with Slevomat's DuplicateSpacesSniff The latter provides a fixer too. --- .../Sniffs/WhiteSpace/TabAndSpaceSniff.php | 60 ------------------- .../Tests/WhiteSpace/TabAndSpaceUnitTest.inc | 3 - .../Tests/WhiteSpace/TabAndSpaceUnitTest.php | 27 --------- CakePHP/ruleset.xml | 5 ++ docs/README.md | 6 +- 5 files changed, 8 insertions(+), 93 deletions(-) delete mode 100644 CakePHP/Sniffs/WhiteSpace/TabAndSpaceSniff.php delete mode 100644 CakePHP/Tests/WhiteSpace/TabAndSpaceUnitTest.inc delete mode 100644 CakePHP/Tests/WhiteSpace/TabAndSpaceUnitTest.php diff --git a/CakePHP/Sniffs/WhiteSpace/TabAndSpaceSniff.php b/CakePHP/Sniffs/WhiteSpace/TabAndSpaceSniff.php deleted file mode 100644 index 5b179ed1..00000000 --- a/CakePHP/Sniffs/WhiteSpace/TabAndSpaceSniff.php +++ /dev/null @@ -1,60 +0,0 @@ -getTokens(); - - $line = $tokens[$stackPtr]['line']; - if ($stackPtr > 0 && $tokens[$stackPtr - 1]['line'] !== $line) { - return; - } - - if (strpos($tokens[$stackPtr]['content'], ' ') !== false) { - $error = 'Double space found'; - $phpcsFile->addError($error, $stackPtr, 'DoubleSpace'); - } - if (strpos($tokens[$stackPtr]['content'], " \t") !== false) { - $error = 'Space and tab found'; - $phpcsFile->addError($error, $stackPtr, 'SpaceAndTab'); - } - if (strpos($tokens[$stackPtr]['content'], "\t ") !== false) { - $error = 'Tab and space found'; - $phpcsFile->addError($error, $stackPtr, 'TabAndSpace'); - } - } -} diff --git a/CakePHP/Tests/WhiteSpace/TabAndSpaceUnitTest.inc b/CakePHP/Tests/WhiteSpace/TabAndSpaceUnitTest.inc deleted file mode 100644 index 08aa478a..00000000 --- a/CakePHP/Tests/WhiteSpace/TabAndSpaceUnitTest.inc +++ /dev/null @@ -1,3 +0,0 @@ - 1, - 3 => 1, - ]; - } - - /** - * @inheritDoc - */ - public function getWarningList() - { - return []; - } -} diff --git a/CakePHP/ruleset.xml b/CakePHP/ruleset.xml index f4d87d26..95b9be50 100644 --- a/CakePHP/ruleset.xml +++ b/CakePHP/ruleset.xml @@ -255,6 +255,11 @@ + + + + + diff --git a/docs/README.md b/docs/README.md index f88e5ed8..3ee63620 100644 --- a/docs/README.md +++ b/docs/README.md @@ -2,7 +2,7 @@ The CakePHP standard contains 155 sniffs -CakePHP (19 sniffs) +CakePHP (18 sniffs) ------------------- - CakePHP.Classes.ReturnTypeHint - CakePHP.Commenting.DocBlockAlignment @@ -22,7 +22,6 @@ CakePHP (19 sniffs) - CakePHP.WhiteSpace.FunctionClosingBraceSpace - CakePHP.WhiteSpace.FunctionOpeningBraceSpace - CakePHP.WhiteSpace.FunctionSpacing -- CakePHP.WhiteSpace.TabAndSpace Generic (26 sniffs) ------------------- @@ -95,7 +94,7 @@ PSR12 (17 sniffs) - PSR12.Properties.ConstantVisibility - PSR12.Traits.UseDeclaration -SlevomatCodingStandard (52 sniffs) +SlevomatCodingStandard (53 sniffs) ---------------------------------- - SlevomatCodingStandard.Arrays.TrailingArrayComma - SlevomatCodingStandard.Attributes.AttributeAndTargetSpacing @@ -149,6 +148,7 @@ SlevomatCodingStandard (52 sniffs) - SlevomatCodingStandard.TypeHints.ReturnTypeHintSpacing - SlevomatCodingStandard.Variables.DuplicateAssignmentToVariable - SlevomatCodingStandard.Variables.UnusedVariable +- SlevomatCodingStandard.Whitespaces.DuplicateSpaces Squiz (27 sniffs) -----------------