Skip to content

Commit 3a7323b

Browse files
committed
ci: fix host-cpp-tests label check to match the actual "Host 🏡" label
The job checked for a label literally named "host", but the repository's real label (used on issues, e.g. #428/#420/#412) is "Host 🏡" — a label named plain "host" existed too, seemingly a leftover/duplicate, and has since been deleted. The condition never actually matched the label anyone would apply in practice, so this job only ever ran on pushes to main/next, never on a labeled PR. Found while attaching labels to this PR: the CI still showed green with host-cpp-tests silently not running, exactly the kind of gap .claude/CLAUDE.md (#436) exists to prevent. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DaK9eAAF5G8wj6UT8VekAm
1 parent 2fae63a commit 3a7323b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

.github/workflows/check.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ jobs:
154154
ctest --test-dir build --output-on-failure
155155
working-directory: packages/weak-node-api
156156
host-cpp-tests:
157-
if: github.ref == 'refs/heads/main' || github.ref == 'refs/heads/next' || contains(github.event.pull_request.labels.*.name, 'host')
157+
if: github.ref == 'refs/heads/main' || github.ref == 'refs/heads/next' || contains(github.event.pull_request.labels.*.name, 'Host 🏡')
158158
strategy:
159159
fail-fast: false
160160
matrix:

0 commit comments

Comments
 (0)