fix(node-tests): declare assert dependency, fail bundling on unresolved imports (#385)

* fix(node-tests): declare assert dependency and fail bundling on unresolved imports

The bundled Node.js test for 2_function_arguments requires 'assert', which
was previously satisfied as a phantom dependency: npm workspaces hoisted
node-addon-examples' assert@2.1.0 ponyfill to the root node_modules, where
rolldown resolved and inlined it. Under pnpm's strict node_modules layout the
package is no longer reachable from node-tests, so rolldown silently kept a
runtime __require("assert") call in the bundle (UNRESOLVED_IMPORT is only a
warning), which then fails at runtime on device where Metro cannot resolve it.

The failure surfaced as the masked 'test.titlePath(...).forEach is not a
function' error, a secondary crash in mocha-remote-server's failure formatter.

Declaring assert as a dependency of node-tests lets rolldown inline it again.
Also make the bundle step fail hard on unresolved imports, so any future
phantom dependency breaks bootstrap loudly instead of failing masked on-device.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MBr6N8caYidCuijvV5ak2A

* ci: trigger label-gated jobs

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MBr6N8caYidCuijvV5ak2A

---------

Co-authored-by: Claude <noreply@anthropic.com>

Author: kraenhansen

packages/node-tests/package.json

@@ -26,6 +26,7 @@
     "bootstrap": "node --run copy-tests && node --run gyp-to-cmake && node --run build-tests && node --run bundle && node --run generate-entrypoint"
   },
   "devDependencies": {
+    "assert": "^2.1.0",
     "cmake-rn": "workspace:*",
     "gyp-to-cmake": "workspace:*",
     "react-native-node-api": "workspace:*",

packages/node-tests/rolldown.config.mts

@@ -23,6 +23,24 @@ function readGypTargetNames(gypFilePath: string): string[] {
   });
 }
 
+/**
+ * Fail the build on unresolved imports instead of emitting a warning:
+ * Anything the bundle can't resolve (besides the addons declared as external)
+ * would otherwise only fail at runtime on device, where Metro's runtime require
+ * masks the underlying error.
+ */
+function failOnUnresolvedImports(
+  warning: Parameters<NonNullable<RolldownOptions["onwarn"]>>[0],
+  defaultHandler: Parameters<NonNullable<RolldownOptions["onwarn"]>>[1],
+) {
+  if (warning.code === "UNRESOLVED_IMPORT") {
+    throw new Error(
+      `Unresolved import: ${warning.message} - add the package as a dependency of @react-native-node-api/node-tests`,
+    );
+  }
+  defaultHandler(warning);
+}
+
 function testSuiteConfig(suitePath: string): RolldownOptions[] {
   const testFiles = fs.globSync("*.js", {
     cwd: suitePath,
@@ -32,6 +50,7 @@ function testSuiteConfig(suitePath: string): RolldownOptions[] {
   const targetNames = readGypTargetNames(gypFilePath);
   return testFiles.map((testFile) => ({
     input: path.join(suitePath, testFile),
+    onwarn: failOnUnresolvedImports,
     output: {
       file: path.join(suitePath, path.basename(testFile, ".js") + ".bundle.js"),
     },