Skip to content

Commit dbd5585

Browse files
committed
fix(host): make vendor-hermes --silent actually silent
The spinners were passed `isEnabled: !silent`. A disabled ora spinner still writes `- <text>` on start and the success/fail symbol on completion (to stderr) — it only skips the animation. `isSilent` is the option that suppresses output entirely. Callers capture stdout only (`$(... --silent)` in CI and the Gradle error message, backticks in patch-hermes.rb), so the stray output was noise rather than a broken path, but `--silent` now does what it says. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HX4imsygeawVtsmoP1sj3F
1 parent 58b213c commit dbd5585

2 files changed

Lines changed: 13 additions & 2 deletions

File tree

.changeset/silent-vendor-hermes.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
---
2+
"react-native-node-api": patch
3+
---
4+
5+
Make `vendor-hermes --silent` actually silent. The spinners were passed
6+
`isEnabled: false`, which stops the animation but still writes the spinner text
7+
and its final symbol to stderr. They now use `isSilent`, which suppresses the
8+
output entirely, leaving the vendored Hermes path on stdout as the command's
9+
only output.

packages/host/src/node/cli/hermes.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,9 @@ export const command = new Command("vendor-hermes")
8585
successText: "Removed existing Hermes clone",
8686
failText: (error) =>
8787
`Failed to remove existing Hermes clone: ${error.message}`,
88-
isEnabled: !silent,
88+
// Not `isEnabled: false`: a disabled spinner still writes its text
89+
// and final symbol to stderr, so `--silent` wasn't silent.
90+
isSilent: silent,
8991
},
9092
);
9193
}
@@ -118,7 +120,7 @@ export const command = new Command("vendor-hermes")
118120
text: `Cloning Hermes into ${prettyPath(hermesPath)}`,
119121
successText: "Cloned Hermes",
120122
failText: (err) => `Failed to clone Hermes: ${err.message}`,
121-
isEnabled: !silent,
123+
isSilent: silent,
122124
},
123125
);
124126
} catch (error) {

0 commit comments

Comments
 (0)