From 00ad3c3baba709a4a18224ca082b5c41154b0dfc Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed, 19 Nov 2025 06:06:00 +0000 Subject: [PATCH 1/4] modified: docs/how-to/upgrade.md --- docs/how-to/upgrade.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/how-to/upgrade.md b/docs/how-to/upgrade.md index 46fcb914..808945db 100644 --- a/docs/how-to/upgrade.md +++ b/docs/how-to/upgrade.md @@ -4,4 +4,4 @@ Upgrade the `github-runner-image-builder-operator` charm with the `refresh` comm ```bash juju refresh github-runner-image-builder -``` +``` \ No newline at end of file From acc7099fb099dadfc080d5a03efe3bb1b7d87245 Mon Sep 17 00:00:00 2001 From: "Sebastien Georget (charmkeeper)" Date: Thu, 18 Jun 2026 15:17:04 +0200 Subject: [PATCH 2/4] Add missing pull-requests write permission to bot_pr_approval job The bot_pr_approval job uses github.rest.pulls.createReview() which requires write access to pull requests. Added the necessary permission at the job level as per GitHub Actions best practices. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .github/workflows/bot_pr_approval.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/bot_pr_approval.yaml b/.github/workflows/bot_pr_approval.yaml index e38c5841..8629e3e9 100644 --- a/.github/workflows/bot_pr_approval.yaml +++ b/.github/workflows/bot_pr_approval.yaml @@ -5,5 +5,7 @@ on: jobs: bot_pr_approval: + permissions: + pull-requests: write uses: canonical/operator-workflows/.github/workflows/bot_pr_approval.yaml@main secrets: inherit From f7b0e35c695af6eed89b7e62330e0a5f4a979199 Mon Sep 17 00:00:00 2001 From: "Sebastien Georget (charmkeeper)" Date: Thu, 18 Jun 2026 22:48:31 +0200 Subject: [PATCH 3/4] fix: add condition to skip bot PRs in bot_pr_approval workflow Update bot_pr_approval.yaml to match the reference template from platform-engineering-charm-template. Added the 'if' condition to prevent the workflow from running on bot-generated pull requests (github-actions[bot]). This condition ensures the approval workflow only runs on human-authored PRs, preventing unnecessary workflow executions on bot-generated changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .github/workflows/bot_pr_approval.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/bot_pr_approval.yaml b/.github/workflows/bot_pr_approval.yaml index 8629e3e9..887a994a 100644 --- a/.github/workflows/bot_pr_approval.yaml +++ b/.github/workflows/bot_pr_approval.yaml @@ -5,7 +5,8 @@ on: jobs: bot_pr_approval: + if: github.event.pull_request.user.login != 'github-actions[bot]' + uses: canonical/operator-workflows/.github/workflows/bot_pr_approval.yaml@main permissions: pull-requests: write - uses: canonical/operator-workflows/.github/workflows/bot_pr_approval.yaml@main secrets: inherit From 350b2524979d34699546df7c2ed7f0303e080a8d Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 6 Jul 2026 12:29:11 +0000 Subject: [PATCH 4/4] docs: replace cloud-init link that fails linkcheck --- docs/reference/charm-architecture.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/reference/charm-architecture.md b/docs/reference/charm-architecture.md index e86ccd4b..ab9d22d5 100644 --- a/docs/reference/charm-architecture.md +++ b/docs/reference/charm-architecture.md @@ -44,7 +44,7 @@ which can then be reused by the other charm to spawn VM instances with the neces The image-builder uses the [OpenStack SDK](https://docs.openstack.org/openstacksdk/latest/) to spawn a VM instance in a cloud specified by a config option. Using an external OpenStack VM instead of the charm's machine allows for more features (using chroot has some limitations, e.g. for building snaps) and parallel image building. -[cloud-init](https://cloud-init.io/) is used to install the necessary dependencies for spawning self-hosted runners +[cloud-init](https://github.com/canonical/cloud-init) is used to install the necessary dependencies for spawning self-hosted runners ([GitHub Actions runner binary](https://github.com/actions/runner)) and tools for automatic proxy support ([aproxy](https://github.com/canonical/aproxy)). There is also a custom script configuration combined with a secret that is run in the cloud-init script to allow further customization of the images. The image-builder repeatedly checks to see if the cloud-init script has finished successfully, then snapshots the VM, uploads the image to a specified OpenStack project