refactor: inline remaining single-use wrappers

Inline terminal key persistence and migration file discovery at their only call sites. Focused lookup/bootstrap tests, lint, RBS validation, and Steep pass.

See #79

Author: cardmagic

lib/solid_objects/executor.rb

@@ -405,7 +405,9 @@ def fail_message(error)
         if error.is_a?(NonRetryableError) ||
             locked_message.attempt_count >= locked_message.max_attempts
           create_dead_letter(message: locked_message, error_details:, now:)
-          remember_key(instance, locked_message)
+          if locked_message.idempotency_key
+            instance.update!(completed_idempotency_keys: remembered_keys(instance, locked_message))
+          end
           dead = true
         else
           ReadyMessage.create!(
@@ -475,13 +477,6 @@ def matching_claim!
       raise LostActivation, "message claim changed"
     end
 
-    # @rbs (Instance, Message) -> void
-    def remember_key(instance, message)
-      return unless message.idempotency_key
-
-      instance.update!(completed_idempotency_keys: remembered_keys(instance, message))
-    end
-
     # @rbs (Instance, Message) -> Array[Hash[String, untyped]]
     def remembered_keys(instance, message)
       remembered = Array(instance.completed_idempotency_keys)

lib/solid_objects/schema_bootstrap.rb

@@ -17,18 +17,11 @@ def install(connection: nil)
 
       # @rbs () -> Array[Class]
       def migrations
-        migration_files.map do |file|
+        Dir[File.expand_path("../../db/migrate/*.rb", __dir__)].sort.map do |file|
           require file
           Object.const_get(File.basename(file, ".rb").sub(/\A\d+_/, "").camelize)
         end
       end
-
-      private
-
-      # @rbs () -> Array[String]
-      def migration_files
-        Dir[File.expand_path("../../db/migrate/*.rb", __dir__)].sort
-      end
     end
   end
 end

sig/generated/lib/solid_objects/executor.rbs

@@ -94,9 +94,6 @@ module SolidObjects
     # @rbs () -> ClaimedMessage
     def matching_claim!: () -> ClaimedMessage
 
-    # @rbs (Instance, Message) -> void
-    def remember_key: (Instance, Message) -> void
-
     # @rbs (Instance, Message) -> Array[Hash[String, untyped]]
     def remembered_keys: (Instance, Message) -> Array[Hash[String, untyped]]
 

sig/generated/lib/solid_objects/schema_bootstrap.rbs

@@ -7,8 +7,5 @@ module SolidObjects
 
     # @rbs () -> Array[Class]
     def self.migrations: () -> Array[Class]
-
-    # @rbs () -> Array[String]
-    private def self.migration_files: () -> Array[String]
   end
 end