refactor: inline the redrive filter validation

Two public helpers validated one argument each, with one caller and a
generated signature apiece. They are guard clauses in `redrive` now.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: cardmagic

lib/solid_objects/dead_letter_scope.rb

@@ -51,33 +51,24 @@ def retry(identifier_value, authorization_context: nil)
 
     # @rbs (?actor_type: String?, ?failed_after: untyped, ?limit: Integer?, ?authorization_context: untyped) -> RedriveTask
     def redrive(actor_type: nil, failed_after: nil, limit: nil, authorization_context: nil)
+      if failed_after && !failed_after.respond_to?(:utc)
+        raise ArgumentError, "failed_after must be a time"
+      end
+      if limit && !(limit.is_a?(Integer) && limit.positive?)
+        raise ArgumentError, "limit must be a positive integer"
+      end
+
       SolidObjects.redrives.start(
         scope: self,
         filters: {
           "actor_type" => actor_type,
-          "failed_after" => failed_after_filter(failed_after),
-          "limit" => limit_filter(limit)
+          "failed_after" => failed_after&.utc&.iso8601(6),
+          "limit" => limit
         },
         authorization_context:
       )
     end
 
-    # @rbs (untyped) -> String?
-    def failed_after_filter(failed_after)
-      return nil if failed_after.nil?
-      raise ArgumentError, "failed_after must be a time" unless failed_after.respond_to?(:utc)
-
-      failed_after.utc.iso8601(6)
-    end
-
-    # @rbs (untyped) -> Integer?
-    def limit_filter(limit)
-      return nil if limit.nil?
-      return limit if limit.is_a?(Integer) && limit.positive?
-
-      raise ArgumentError, "limit must be a positive integer"
-    end
-
     # @rbs () -> ActiveRecord::Relation[untyped]
     def dead
       model.where(status: DEAD)

sig/generated/lib/solid_objects/dead_letter_scope.rbs

@@ -31,12 +31,6 @@ module SolidObjects
     # @rbs (?actor_type: String?, ?failed_after: untyped, ?limit: Integer?, ?authorization_context: untyped) -> RedriveTask
     def redrive: (?actor_type: String?, ?failed_after: untyped, ?limit: Integer?, ?authorization_context: untyped) -> RedriveTask
 
-    # @rbs (untyped) -> String?
-    def failed_after_filter: (untyped) -> String?
-
-    # @rbs (untyped) -> Integer?
-    def limit_filter: (untyped) -> Integer?
-
     # @rbs () -> ActiveRecord::Relation[untyped]
     def dead: () -> ActiveRecord::Relation[untyped]