fix: name every migrated column in the doctor

`EXPECTED_COLUMNS` omitted `instances.state_revision`, so the doctor
passed on a schema that stops a worker. The list had drifted the same
way four other times, and the earlier fix named one column rather than
the rule.

A test now applies the first migration to one scratch database and every
migration to another, and fails when the doctor does not name a column
that the later migrations add. A new table is skipped, because the
missing-table check already reports it. The test failed with:

    Expected ["instances.state_revision", "messages.operation",
    "effects.success_operation", "effects.failure_operation",
    "dead_letters.operation"] to be empty.

The TypeScript doctor needs no equivalent. It compares the recorded
migration versions against `SCHEMA_VERSIONS`, which reports any
migration that did not run. The gem cannot do that, because a host
application copies these migrations under its own timestamps, so the
column list is the only signal Ruby has.

Validation: bundle exec rake (784 runs, 0 failures) and the full suite
on PostgreSQL 16 (784 runs, 0 failures).

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: cardmagic

lib/solid_objects/doctor.rb

@@ -65,22 +65,25 @@ def to_s
       instances: %w[
         id actor_type actor_id state state_version next_message_sequence
         activation_owner_id activation_token activation_expires_at
-        activation_generation completed_idempotency_keys
+        activation_generation state_revision completed_idempotency_keys
       ],
       messages: %w[
-        id instance_id delivery_mode arguments sequence attempt_count request_id
-        result error rejection completed_at rejected_at
+        id instance_id operation delivery_mode arguments sequence attempt_count
+        request_id result error rejection completed_at rejected_at
       ],
       ready_messages: %w[id message_id instance_id sequence available_at],
       claimed_messages: %w[
         id message_id instance_id process_id activation_token
         activation_generation claimed_at
       ],
       reminders: %w[id instance_id operation next_run_at status],
-      effects: %w[id message_id instance_id effect_id status available_at],
+      effects: %w[
+        id message_id instance_id effect_id status available_at
+        success_operation failure_operation
+      ],
       effect_recoveries: %w[effect_id instance_id recovery_operation status_operation recovery_timeout retired_at],
       broadcasts: %w[id message_id instance_id broadcast_id status available_at],
-      dead_letters: %w[id message_id instance_id actor_type actor_id attempts],
+      dead_letters: %w[id message_id instance_id actor_type actor_id operation attempts],
       administration_events: %w[id action kind subject_id actor occurred_at],
       redrives: %w[id kind filters status active_scope moved move_limit started_at finished_at]
     }.freeze

test/integration/doctor_test.rb

@@ -3,6 +3,12 @@
 require "database_test_helper"
 require "rake"
 require "solid_objects/doctor"
+require "solid_objects/schema_bootstrap"
+require "tmpdir"
+
+class DoctorScratchSchema < ActiveRecord::Base
+  self.abstract_class = true
+end
 
 class DoctorTest < ActiveSupport::TestCase
   test "verifies a workerless synchronous installation" do
@@ -132,6 +138,18 @@ class DoctorTest < ActiveSupport::TestCase
     assert_match(/completed_idempotency_keys/, report.check(:schema).message)
   end
 
+  test "names a column from every migration that follows the first" do
+    added = columns_later_migrations_add
+
+    refute_empty added, "the schema has no migration after the first to verify"
+    unnamed = added.flat_map do |table, columns|
+      listed = SolidObjects::Doctor::EXPECTED_COLUMNS.fetch(table, [])
+      (columns - listed).map { |column| "#{table}.#{column}" }
+    end
+
+    assert_empty unnamed, "the doctor cannot report these half-applied migrations"
+  end
+
   test "reports live runtime roles" do
     now = SolidObjects.database_adapter.database_now
     SolidObjects::Process.create!(
@@ -166,6 +184,41 @@ class DoctorTest < ActiveSupport::TestCase
 
   private
 
+  # @rbs () -> Hash[Symbol, Array[String]]
+  def columns_later_migrations_add
+    Dir.mktmpdir do |directory|
+      migrations = SolidObjects::SchemaBootstrap.migrations
+      first = schema_columns(directory, "first", migrations.first(1))
+      whole = schema_columns(directory, "whole", migrations)
+      first.each_with_object({}) do |(table, columns), added|
+        later = whole.fetch(table) - columns
+        added[table] = later unless later.empty?
+      end
+    end
+  end
+
+  # @rbs (String, String, Array[Class]) -> Hash[Symbol, Array[String]]
+  def schema_columns(directory, name, migrations)
+    DoctorScratchSchema.establish_connection(
+      adapter: "sqlite3",
+      database: File.join(directory, "#{name}.sqlite3")
+    )
+    connection = DoctorScratchSchema.connection
+    migrations.each do |migration_class|
+      migration = migration_class.new
+      migration.define_singleton_method(:connection) { connection }
+      migration.migrate(:up)
+    end
+    SolidObjects::Doctor::EXPECTED_COLUMNS.keys.each_with_object({}) do |table, columns|
+      name = SolidObjects.table_name(table)
+      next unless connection.data_sources.include?(name)
+
+      columns[table] = connection.columns(name).map(&:name)
+    end
+  ensure
+    DoctorScratchSchema.remove_connection
+  end
+
   def hold_sqlite_write_lock
     locked = Queue.new
     release = Queue.new