Skip to content

Commit f679326

Browse files
cardmagicclaude
andcommitted
refactor: inline the retried-reference branch
`retried_reference` wrapped one branch with one caller. `retry` shows the branch and `enqueue_retry` keeps only the enqueue, which the branch needs a name for. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent c358b0a commit f679326

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

‎lib/solid_objects/dead_letter_manager.rb‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,11 @@ def retry(dead_letter_id, authorization_context: nil)
1414
actor = AdministrationAudit.identity(authorization_context)
1515
SolidObjects.database_adapter.transaction do
1616
dead_letter = DeadLetter.find(dead_letter_id)
17-
reference = retried_reference(dead_letter)
17+
reference = if dead_letter.retried_message_id
18+
MessageReference.from_message(Message.find(dead_letter.retried_message_id))
19+
else
20+
enqueue_retry(dead_letter)
21+
end
1822
AdministrationAudit.record(
1923
action: "dead_letter.retry",
2024
kind: "message",
@@ -48,11 +52,7 @@ def broadcasts
4852
private
4953

5054
# @rbs (DeadLetter) -> MessageReference
51-
def retried_reference(dead_letter)
52-
if dead_letter.retried_message_id
53-
return MessageReference.from_message(Message.find(dead_letter.retried_message_id))
54-
end
55-
55+
def enqueue_retry(dead_letter)
5656
message_reference = Mailbox.new.enqueue(
5757
reference: Reference.new(
5858
actor_type: dead_letter.actor_type,

‎sig/generated/lib/solid_objects/dead_letter_manager.rbs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ module SolidObjects
1717
private
1818

1919
# @rbs (DeadLetter) -> MessageReference
20-
def retried_reference: (DeadLetter) -> MessageReference
20+
def enqueue_retry: (DeadLetter) -> MessageReference
2121

2222
# @rbs (Symbol, authorization_context: untyped, ?dead_letter_id: Integer?) -> void
2323
def authorize!: (Symbol, authorization_context: untyped, ?dead_letter_id: Integer?) -> void

0 commit comments

Comments
 (0)