From 6eb6afdbb77eed1eecdd1065e643c594462619b8 Mon Sep 17 00:00:00 2001 From: "henrydingliu@gmail.com" Date: Sun, 21 Jun 2026 07:15:36 +0000 Subject: [PATCH] more fixes --- chainladder/adjustments/disposal.py | 4 ++-- chainladder/adjustments/tests/test_disposal.py | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/chainladder/adjustments/disposal.py b/chainladder/adjustments/disposal.py index cd4e811d..28b3e728 100644 --- a/chainladder/adjustments/disposal.py +++ b/chainladder/adjustments/disposal.py @@ -211,8 +211,8 @@ def fit( ult = sample_weight.copy() #calculate disposal rate triangle self.xp = X.get_array_module() - self.X_ = X.sort_index() - self.disposal_rate_tri = X / ult.values + self.X_ = X.incr_to_cum().sort_index() + self.disposal_rate_tri = self.X_ / ult.values #get weights for estimation tw = TriangleWeight( n_periods = self.n_periods, diff --git a/chainladder/adjustments/tests/test_disposal.py b/chainladder/adjustments/tests/test_disposal.py index 7f745218..8b298c10 100644 --- a/chainladder/adjustments/tests/test_disposal.py +++ b/chainladder/adjustments/tests/test_disposal.py @@ -50,7 +50,8 @@ def test_cl_parity(raa): def test_sparse_transform(raa): raa_sparse = raa.set_backend('sparse') + ult = cl.Chainladder().fit(raa_sparse).ultimate_.set_backend('sparse') + dr = cl.DisposalRate().fit_transform(raa_sparse,sample_weight=ult) from chainladder.utils.sparse import sp - dr = cl.DisposalRate().fit_transform(raa_sparse,sample_weight=cl.Chainladder().fit(raa_sparse).ultimate_) assert isinstance(dr.full_triangle_.values,sp.COO)