From e94bfb8e1fdaa1878e6a7ad3cd3937b34b0a336b Mon Sep 17 00:00:00 2001 From: Ryan Armstrong Date: Thu, 20 Aug 2026 02:23:35 -0400 Subject: [PATCH] build: pin staticcheck in the Makefile as the workflow does The Makefile claims that check runs the same suite as the test workflow, but it pinned staticcheck at 2025.1.1 while the workflow moved to 2026.2rc1 in 41a8215. staticcheck reads the export data of the toolchain it runs under, so the stale pin fails on Go 1.27 with the same import errors that broke CI: internal error in importing "internal/byteorder" (cannot decode "internal/byteorder", export data version 4 is greater than maximum supported version 2) Match the workflow, and carry its reasoning across so the release candidate is not mistaken for an oversight and downgraded to the latest stable release, which is 2026.1 and does not read Go 1.27 either. Co-Authored-By: Claude Opus 5 --- Makefile | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index bda2fa3..738c4b6 100644 --- a/Makefile +++ b/Makefile @@ -1,5 +1,11 @@ GO = go -STATICCHECK = honnef.co/go/tools/cmd/staticcheck@2025.1.1 + +# staticcheck reads the export data of the toolchain it runs under, so each +# release only understands the Go versions it shipped alongside. When a new Go +# release breaks the vet target, bump this pin to the first staticcheck that +# reads it, release candidate or not: 2026.2rc1 is the first to read Go 1.27. +# Keep it in step with the staticcheck step in .github/workflows/test.yml. +STATICCHECK = honnef.co/go/tools/cmd/staticcheck@2026.2rc1 all: check