Remove Redis and the Rails.cache layer#619
Merged
Merged
Conversation
Drops the Redis dependency entirely so the Heroku Redis add-on can be removed. ActionCable was configured on Redis but had no channels, broadcasts, or subscriptions. The two Rails.cache call sites (Metric#chart_data and Api::MetricsController#index) had 12h TTLs on data that either invalidates on every push or returns stale values for the CLI API — not worth the infra.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
redis,hiredis, andconnection_poolgems so the Heroku Redis add-on can be destroyed after merge.Rails.cache.fetchcall sites (Metric#chart_data,Api::MetricsController#index) — the 12h TTL wasn't worth the infra given chart data invalidates on every push and the API cache actually returned stale metric data to the CLI.redistoasync(there were no channels, broadcasts, or subscriptions).package-lock.jsonchurn is unrelated npm peer-dep metadata reshuffling already present in the workspace.Test plan
pggem segfault on macOS)heroku addons:destroy heroku-redis --app cherrypush-productionandheroku config:unset REDIS_URL🤖 Generated with Claude Code