Repository navigation
feat(mosaic): show the Add passkey button pending while the passkey request runs - #10447
Closed
austincalvelage wants to merge 1 commit into
Closed
austincalvelage wants to merge 1 commit into
austincalvelage wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 8832dd2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
austincalvelage
force-pushed
the
austin/passkey-add-pending
branch
from
October 27, 2026 02:56
d54c736 to
8832dd2
Compare
austincalvelage
force-pushed
the
austin/contact-verify-pending
branch
from
October 27, 2026 02:56
dbd0823 to
4dd186a
Compare
Member
Author
|
Leaving the Add passkey button as it is. The pending state would stay on through the browser's own passkey prompt. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #10446.
On a slow connection, clicking Add passkey greyed the button out and nothing else happened until the browser's passkey prompt appeared.
Now the button shows a spinner and is marked busy while the passkey request runs. It stops showing pending while the session verification card is open, and stays disabled until the add finishes or fails. It uses the same
SubmitButtonpending state as the Connect button on connected accounts.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change