diff --git a/apps/server-nestjs/src/modules/gitlab/gitlab.service.spec.ts b/apps/server-nestjs/src/modules/gitlab/gitlab.service.spec.ts index 7769d0832a..79ec948070 100644 --- a/apps/server-nestjs/src/modules/gitlab/gitlab.service.spec.ts +++ b/apps/server-nestjs/src/modules/gitlab/gitlab.service.spec.ts @@ -283,7 +283,7 @@ describe('gitlabService', () => { expect.objectContaining({ email: 'owner@example.com' }), expect.objectContaining({ cpnUserId: 'o1' }), ) - expect(gitlab.addGroupMember).toHaveBeenCalledWith(group, 999, AccessLevel.GUEST) + expect(gitlab.addGroupMember).toHaveBeenCalledWith(group, 999, AccessLevel.DEVELOPER) expect(gitlab.addGroupMember).toHaveBeenCalledWith(group, 998, AccessLevel.OWNER) }) @@ -400,7 +400,7 @@ describe('gitlabService', () => { expect(gitlab.addGroupMember).toHaveBeenCalledWith(group, 105, AccessLevel.REPORTER) }) - it('should downgrade existing member to guest when no role maps to an access level', async () => { + it('should downgrade existing member to developer when no role maps to an access level', async () => { const project = makeProjectWithDetails({ roles: [{ id: 'r-unknown', oidcGroup: '/other/group' }], members: [{ user: { id: 'u1', email: 'no-access@example.com', firstName: 'No', lastName: 'Access', adminRoleIds: [] }, roleIds: ['r-unknown'] }], @@ -423,7 +423,7 @@ describe('gitlabService', () => { await service.handleUpsert(project) - expect(gitlab.editGroupMember).toHaveBeenCalledWith(group, 105, AccessLevel.GUEST) + expect(gitlab.editGroupMember).toHaveBeenCalledWith(group, 105, AccessLevel.DEVELOPER) expect(gitlab.removeGroupMember).not.toHaveBeenCalledWith(group, 105) }) diff --git a/apps/server-nestjs/src/modules/gitlab/gitlab.utils.ts b/apps/server-nestjs/src/modules/gitlab/gitlab.utils.ts index be748a6f7e..f72969128e 100644 --- a/apps/server-nestjs/src/modules/gitlab/gitlab.utils.ts +++ b/apps/server-nestjs/src/modules/gitlab/gitlab.utils.ts @@ -82,7 +82,7 @@ export function generateAccessLevelMapping( if (level !== null && level !== undefined && (highest === null || level > highest)) return level return highest }, null) - acc.set(membership.user.id, highest ?? AccessLevel.GUEST) + acc.set(membership.user.id, highest ?? AccessLevel.DEVELOPER) return acc }, new Map()) }