Skip to content

build(cf-package): widen SESSION_STORE_EXPIRY to 4 hours#5372

Merged
norman-abramovitz merged 1 commit into
cloudfoundry:developfrom
nabramovitz:fix/session-store-expiry-adepttech
May 24, 2026
Merged

build(cf-package): widen SESSION_STORE_EXPIRY to 4 hours#5372
norman-abramovitz merged 1 commit into
cloudfoundry:developfrom
nabramovitz:fix/session-store-expiry-adepttech

Conversation

@nabramovitz
Copy link
Copy Markdown
Contributor

Summary

  • build/release-cf.sh heredoc gains SESSION_STORE_EXPIRY: "240" (minutes) under the cf-package manifest's env: block.
  • Default jetstream session expiry is 20 minutes (src/jetstream/main.go:74), read at line 239 with the same default when the env var is unset.
  • This widens the window to 4 hours so long verification / Playwright re-test sessions against a deployed instance don't get interrupted by mid-run cookie expiry.
  • No code-side behavior change — only the cf-package manifest emitted by make release cf carries the new env var.

Test plan

  • make build release cf and inspect dist/cf-package/manifest.yml for the new line under env:
  • make deploy cf to a test foundation and verify with cf env console | grep SESSION_STORE_EXPIRY
  • Log in and confirm session survives past the 20-minute default (smoke check; full 4-hour observation optional)

Related

  • The original feature request to make this env-configurable was triaged today as fixed (closed during issue-backlog cleanup) — this PR is the cf-package deploy-side wiring.

Default jetstream session expiry is 20 minutes (main.go:74), which
makes long Playwright MCP sessions against adepttech painful — the
session cookie expires before a multi-ticket verification pass
finishes, forcing a re-login mid-run.

Wire SESSION_STORE_EXPIRY=240 (4 hours) into the cf-package manifest
heredoc so it carries forward every `make deploy cf` and adepttech
deploys come up with a session window long enough to drive a re-test
session without auth interruptions.

The env var is read at src/jetstream/main.go:239 with a 20-minute
fallback when unset, so this only widens the window — no other
behavior change.
Copy link
Copy Markdown
Contributor

@norman-abramovitz norman-abramovitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@norman-abramovitz norman-abramovitz merged commit 26467fc into cloudfoundry:develop May 24, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants