Repository navigation
fix: Set file max-target-bytes to 150Kb TAROT-3746 - #25
Conversation
lolgab
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the --max-target-bytes parameter value from "0" to "150000" in the test file internal/tool/command_test.go. However, the reviewer noted that this change causes TestCreateCommandParameters to fail because the actual implementation in internal/tool/command.go still uses "0" and needs to be updated to match the test.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "--timeout", "10", | ||
| "--timeout-threshold", "5", | ||
| "--max-target-bytes", "0", | ||
| "--max-target-bytes", "150000", |
There was a problem hiding this comment.
Updating the test expectation to "150000" without updating the actual implementation in internal/tool/command.go (which still uses "0" on line 86) causes TestCreateCommandParameters to fail. The implementation in internal/tool/command.go needs to be updated to "150000" to match this test and complete the fix.
Up to standards ✅🟢 Issues
|
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
This Pull Request is incomplete as it only modifies the test suite (internal/tool/command_test.go) and fails to implement the required --max-target-bytes flag in the production code logic. While the existing test changes indicate an intent to set a 150,000-byte limit, the scanner's behavior remains unchanged. Additionally, the chosen limit of 150 KB is relatively small for many source code projects and may lead to unintentional skipping of files; this threshold and the use of decimal (KB) versus binary (KiB) units should be verified against the requirements for TAROT-3746.
About this PR
- The production code changes are missing. This PR only updates
internal/tool/command_test.go, meaning the--max-target-bytesflag is not actually implemented in the command execution logic. - Please provide a description for the PR to explain the context of the changes and confirm if this is a partial submission.
Test suggestions
- Verify that createCommandParameters includes the --max-target-bytes flag with the value 150000 in the returned parameter list.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
No description provided.