🤖 feat: unify reasoning picker between chat composer and Agents settings - #3887
🤖 feat: unify reasoning picker between chat composer and Agents settings#3887ibetitsmike wants to merge 16 commits into
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5ff5f3db0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 20edfe77ca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a937067819
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c3188ef10
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca2bb19aa2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a46665bad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 122b930f99
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 801b461d7a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
The Agents settings page used a plain Select for reasoning that only listed thinking levels, so per-model features in the chat picker (Pro mode for the GPT-5.6 family, Fast mode for OpenAI/Grok frontier models) were impossible to configure there and the two controls drifted in styling. - Extract ThinkingSelectorControl: a controlled variant of the chat thinking picker owning policy resolution + route-aware Pro/Fast availability, with a "composer" (chat input) and "box" (settings form field) variant plus an optional Inherit row. ThinkingSelector is now a thin wrapper binding it to ThinkingContext, so future picker changes apply to both surfaces. - Add reasoningMode to AgentAiDefaultsEntry/SubagentAiDefaultsEntry (sparse: only explicit "pro" is persisted) and plumb it through normalizers, the TasksSection save path, workspace mode sync, task/workspace-turn resolution, ACP agent defaults, heartbeat/idle-compaction sends, and compaction override paths, mirroring thinkingLevel precedence. --- _Generated with `mux` • Model: `anthropic:claude-fable-5` • Thinking: `xhigh`_ <!-- mux-attribution: model=anthropic:claude-fable-5 thinking=xhigh -->
Remote UAT found the bottom agent row's menu opened below the settings fold with no auto-scroll.
…f per-field fallback Codex review: ACP mode switches, model changes, and thinking-level changes rebuilt persisted AI settings without reasoningMode, silently dropping pro; goal-continuation kickoff skipped model-less candidates entirely, ignoring reasoning-only agent defaults.
…tandard override of inherited pro Codex round 2: the plan-to-exec handoff ignored effectiveReasoningMode from resolveTaskAISettings (configured exec sub-agent/agent pro defaults never applied), and the Exec sub-agent row's pro toggle could not disable an inherited pro because turning it off deleted the already-absent override.
…clears reasoning override Codex round 3 follow-ons: setAgentReasoningMode deleted overrides that ACP's base-chain resolution then re-filled with an ancestor's pro, and the Inherit action retained an invisible explicit-standard reasoning override with no way to remove it.
Codex round 4: Dream's headless requests (raw streamText) never apply reasoningMode, so the card offered a toggle that could not affect them; and cards without a direct override displayed standard while ACP base-chain resolution ran pro, making the first toggle click a no-op.
…AppConfigStore Codex round 5: agent cards gated Pro on the ambient default model even when the base chain supplied a pro-capable one, hiding an active inherited pro; and every ThinkingSelectorControl instance opened its own config.getConfig fetch + onConfigChanged subscription via useRouting/useMinThinkingLevels (O(rows) fan-out on the Agents settings page). AppConfigStore mirrors ProvidersConfigStore: one fetch + one subscription per app session.
…es and creation Codex round 6: the desktop mode-switch resolver read only the direct agentAiDefaults entry (custom agents with base: exec never inherited an ancestor's pro), and the creation sync copied only model/thinking so a configured pro default missed the first turn of new workspaces. resolveConfiguredReasoningModeDefault mirrors ACP's base-chain walk and is shared by both paths.
… hide Pro on Name Workspace card Codex round 7: resolveTaskAISettings consulted only the target agent's own defaults before parent fallbacks, so Explore never inherited a pro configured on its Exec base (unlike Settings display and ACP resolution); and the Name Workspace card offered Pro even though name generation runs raw streamText (same headless class as Dream, now a shared exclusion set).
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Codex round 8: the sync approximation hardcoded every non-plan agent to inherit its reasoning default from exec; a custom sub-agent with base: plan (or a custom ancestor) now resolves its definition's actual chain at Task.create/createMany time (readAgentDefinition + resolveAgentInheritanceChain, ACP-parity fallback terminus), keeping the approximation only where definitions are unreadable or callers are sync (plan handoff targets literal exec, where the approximation is exact).
9355ea8 to
cdf18a5
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cdf18a5539
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…eclared base chains Codex round 9: - TasksSection now slots a definition-pinned ai.model below Settings overrides and above the ambient fallback (mirrors resolveAgentAiSettings), so definition-pinned GPT-5.6 agents expose the Pro toggle. - Goal-continuation kickoff options resolve the selected agent's declared base chain (shared resolveDeclaredBaseChainIds, extracted from taskService) instead of hardcoding the Exec fallback, so base: plan custom agents inherit Plan's configured defaults.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac6ff76ffb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…reasoning, refresh routing on failed writes Codex round 10: - removeMirroredExecSubagentDefaults now compares and retains reasoningMode, so a differing sub-agent override (UI Exec pro + sub-agent standard) survives startup cleanup instead of silently flipping to pro. - Heartbeat send options resolve reasoningMode through the selected agent's declared base chain (shared resolveWorkspaceAgentBaseChainIds, also used by goal kickoffs) instead of a hardcoded Exec fallback. - useRouting refreshes the shared AppConfigStore when updateRoutePreferences fails, reverting the optimistic route instead of letting stale state survive navigation (same recovery as useMinThinkingLevels).
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 038ab8f4fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…'s declared base Codex round 11: - resolveWorkspaceAiSettingsForAgent resolves model/thinking field-wise through DECLARED base chains alongside reasoningMode, so a custom agent inheriting GPT-5.6 + pro from its base persists both together instead of pro beside an Anthropic workspace model where gating drops it. The implicit unknown-agent fallback still contributes reasoningMode only, preserving desktop switches that keep the workspace's current model. - resolveWorkspaceAgentBaseChainIds no longer assumes agents named exec are the unmodified built-in: a project-scoped exec.md with base: plan now resolves Plan's defaults for goal kickoffs and heartbeats.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 848bf2e5bb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…beat model/thinking through declared chains Codex round 12: - /compact (applyCompactionOverrides) resolves compact's configured base chain (compact -> exec) for reasoningMode, so a saved Exec pro default reaches compaction as the Settings card displays. - Backend idle compaction gets the same chain-walk (same defect class: it consulted workspace exec settings but never config agentAiDefaults). - Heartbeats resolve model and thinking through the declared base chain alongside reasoningMode; resolving only some fields combined Plan's pro with Exec's Anthropic model, where gating drops pro.
|
@codex review |
…e in package.json (#3898 broke main: updater.ts derives feed repo from package.json repository URL)
1 participant
Summary
Unifies the reasoning picker so the chat composer and the Settings -> Agents cards share one
ThinkingSelectorcomponent and one resolution model: an agent's effective model and reasoning default resolve through its declared base chain, and every consumer (sub-agent spawn, goal kickoff, heartbeat, mode switch, ACP config, compaction) uses the same chain-aware fallback.Background
The chat composer and the per-agent settings cards previously had separate reasoning UIs with divergent semantics. Settings-configured reasoning defaults were ignored or inconsistently applied on several paths (task spawning, plan handoff, goal kickoff, heartbeats, desktop mode switches), and Pro availability was gated on the wrong model when an agent inherited its model from a base agent.
Implementation
ThinkingSelectorgains a box variant used by the Agents settings cards; both surfaces share option gating, keyboard handling, and Inherit semantics (choosing Inherit clears the stored override instead of persisting a copy).resolveDeclaredBaseChainIdsresolves an agent's ordered ancestor IDs from its definition files with ACP-parity terminal fallback (plan -> plan, else exec).taskService,workspaceGoalService,workspaceService(heartbeats, mode sync), and ACPconfigOptionsresolve model/thinking through this declared chain instead of hardcoded per-agent lookups.AppConfigStorecentralizes config fetches so pickers share one subscription; routing refreshes when config writes fail so the UI does not show a state that was never persisted.Also includes an unrelated one-line rider:
updater.test.tsfeed expectations updated fromrepo: "mux"torepo: "shux". Main was broken by #3898 (package.json repository URL renamed to coder/shux while the updater derives its feed repo from it), which failed every merge-queue run including this PR's; fixing it here repairs main via this squash merge.Validation
taskService.test.ts,workspaceService.test.ts,workspaceGoalService.test.ts,acp.configOptions.test.ts), Pro gating and Inherit-clears-override (workspaceModeAi.test.ts,agentAiDefaults.test.ts), picker UI flows (TasksSection.ui.test.tsx), routing refresh on failed writes (useRouting.test.ts).bun test src/desktop/updater.test.tspasses on the merged tree.Risks
Medium. Reasoning/model resolution touches every agent-spawn path; a regression would mis-select thinking level or model for sub-agents, heartbeats, or goal kickoff. The chain resolver falls back to the callers' previous sync approximation when definitions cannot be read, so failure degrades to prior behavior rather than erroring.
Generated with
mux• Model:anthropic:claude-fable-5• Thinking:xhigh