Repository navigation
Commit 395ef5e
committed
gtk.cfg: fix the g_ascii_formatd() configuration
g_ascii_formatd(buffer, buf_len, format, d) formats exactly one double
into buffer, but every call was reported as
g_ascii_formatd format string requires 1 parameter but only 0 are given.
Uninitialized variable: buffer
- The double is a fixed argument: with it configured as arg 4 the format
check did not count it. Leave it to the format string check, which now
also checks its type.
- buffer is written, not read: it need not be initialized or a string.
Its size must be at least buf_len.1 parent e5f9f00 commit 395ef5e
2 files changed
Lines changed: 18 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3285 | 3285 | | |
3286 | 3286 | | |
3287 | 3287 | | |
3288 | | - | |
3289 | | - | |
| 3288 | + | |
3290 | 3289 | | |
3291 | 3290 | | |
3292 | 3291 | | |
| |||
3299 | 3298 | | |
3300 | 3299 | | |
3301 | 3300 | | |
3302 | | - | |
3303 | | - | |
3304 | | - | |
3305 | | - | |
3306 | 3301 | | |
3307 | 3302 | | |
3308 | 3303 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
655 | 655 | | |
656 | 656 | | |
657 | 657 | | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
0 commit comments