Navigation bar looks odd

[amotl]

@hammerhead reported:

Hi. Did the documentation theme change lately? The navigation bar on the left looks a bit odd. The grey background is too short on certain pages. In the case of the release notes, the items go into/beyond the footer.

[amotl]

Hi. I've yanked 0.44.0 from PyPI, and commandeered to rebuild the docs. Modulo Fastly cache purging, which is currently defunct, the previous rendering might come back in the next hours.

[amotl]

@bmunkholm already found this last week:

• TOC expand-collapse icons #659 (comment)

[amotl]

By checking each commit since tag 0.42.0, I found 468a4d2 to be the one that possibly makes things go south. With the commit before, b61b343, the rendering works well. I don't know why, because the commit looks innocent.

cd docs; make dev

# Works
git checkout b61b343cb1

# Fails
git checkout 468a4d2ec8

[amotl]

Well, my previous evaluation was wrong. This is one of the occasions when the JS/CSS assets need to be recompiled before making any judgement about the outcome. The Spinx build itself does not re-bundle the assets, you need to reset the build environment between cycles ¹. Now, after checking again, I found 030ebbe to be the offending commit.

cd docs

# Fails
git checkout 030ebbe1988f
make reset
make dev

Going back to the previous commit makes the rendering work well again.

# Works
git checkout 6f599a3edd63
make reset
make dev

Footnotes

1. Alternatively, you need to run the JS/CSS bundler in watching mode in parallel to get an instant experience. ↩

[amotl]

Resolved with release 0.45.0 by reverting the offending commit.